Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disconnect if solo participant #19

Closed
raedah opened this issue Jun 2, 2018 · 3 comments
Closed

Disconnect if solo participant #19

raedah opened this issue Jun 2, 2018 · 3 comments

Comments

@raedah
Copy link
Member

raedah commented Jun 2, 2018

If a client detects that their are no other participants in the join, instead of sending the transaction through the server, the client should instead disconnect and create a normal splittx locally without using the server.

@raedah
Copy link
Member Author

raedah commented Jun 7, 2018

In addition to the above safety check on the client to only go through the server if there are other participants, there should also be a min participants setting on the server. If the minimum number of participants are not connected to the server, the timer will not cause the transaction to be released and will instead wait until the minimum participants have connected.

huyntsgs added a commit that referenced this issue Jun 13, 2018
Disconnect and solo purchaseticket  when only one participant in the join (#19)
@huyntsgs
Copy link
Contributor

Fixed in above commits

@raedah
Copy link
Member Author

raedah commented Jun 17, 2018

Verified working.

@raedah raedah closed this as completed Jun 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants