From 7d99f070acc3011b6d40ca033c015d4808c46f18 Mon Sep 17 00:00:00 2001 From: Peter Scully Date: Tue, 17 Oct 2023 09:21:21 +0700 Subject: [PATCH 1/2] Fix for issue #6 _reliabili.py Fix for #6 , adds argument to FactorAnalyzer call for group factors. ``` n_factors=self.n_factors_f, ``` --- reliabilipy/_reliabili.py | 1 + 1 file changed, 1 insertion(+) diff --git a/reliabilipy/_reliabili.py b/reliabilipy/_reliabili.py index 29d2abd..e45333f 100644 --- a/reliabilipy/_reliabili.py +++ b/reliabilipy/_reliabili.py @@ -182,6 +182,7 @@ def fit(self): # Start Calculations self.fa_f = FactorAnalyzer(rotation=self.rotation_fa_f, method=self.method_fa_f, + n_factors=self.n_factors_f, is_corr_matrix=True) self.fa_f.fit(self.correlations_matrix) self.fa_g = FactorAnalyzer(rotation=None, From 6fcffe6f7cfdaa32331a3f10c67a6740a9426079 Mon Sep 17 00:00:00 2001 From: Peter Scully Date: Wed, 18 Oct 2023 22:29:35 +0700 Subject: [PATCH 2/2] Allow for `None` as rotation method. --- reliabilipy/_reliabili.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/reliabilipy/_reliabili.py b/reliabilipy/_reliabili.py index e45333f..ccc80b4 100644 --- a/reliabilipy/_reliabili.py +++ b/reliabilipy/_reliabili.py @@ -102,7 +102,7 @@ def __init__(self, self.raw_dataset = raw_dataset self.correlations_matrix = correlations_matrix self.method_fa_f = method_fa_f.lower() - self.rotation_fa_f = rotation_fa_f.lower() + self.rotation_fa_f = rotation_fa_f.lower() if rotation_fa_f else rotation_fa_f self.method_fa_g = method_fa_g.lower() self.is_corr_matrix = is_corr_matrix self.n_factors_f = n_factors_f