Rasterize with ext and res uses wrong corners of the Extent

[felixcremer]

When I am running rasterize with a extent as to and a resolution I would have expected that the X axis spans the range of the X extent and the Y axis range of extent.Y. It seems that the X-axis is constructed from the first of the entries in extent and Y from the last entries.
In the example below I would have expected that X has values -1:0.01:1 and Y 0.33:0.01:2

julia> extr =Extent(X=(-1,1.1), Y=(0.33,2));

julia> rasr = rasterize(prand, to=extr, res=0.1, fill=1, reducer=sum)
┌ 14×10 Raster{Union{Missing, Int64}, 2} nothing ┐
├────────────────────────────────────────────────┴─────────────────────────────────────────── dims ┐
  ↓ X Projected{Float64} -1.0:0.1:0.3 ForwardOrdered Regular Intervals{Start},
  → Y Projected{Float64} 1.1:0.1:2.0 ForwardOrdered Regular Intervals{Start}
├──────────────────────────────────────────────────────────────────────────────────────── metadata ┤
  Metadata of Dict{Any, Any}()
├────────────────────────────────────────────────────────────────────────────────────────── raster ┤
  extent: Extent(X = (-1.0, 0.4), Y = (1.1, 2.1))
  missingval: missing
└──────────────────────────────────────────────────────────────────────────────────────────────────┘
 ⋮      ⋱  

[asinghvi17]

That is indeed awkward...probably a typo?

[tiemvanderdeure]

It hits this path

extr =Extent(X=(-1,1.1), Y=(0.33,2));
Rasters._extent(extr; geometrycolumn = nothing)

Which returns Extent(X = (-1.0, 0.33), Y = (1.1, 2.0)) because it treats the extent as 2 x-y points!

[tiemvanderdeure]

While #852 mostly fixes this, maybe there is still room for improvement on how edges are handled.

point = (0.5,0.5)
extr =Extent(X=(-1,1.1), Y=(0.0,2.0));
rasr = rasterize(point, to=extr, res=0.1, fill=1, reducer=sum)
extent(rasr)

Gives Extent(X = (-1.0, 1.2000000000000002), Y = (0.0, 2.1)). So it's like 1 row and 1 column more than I would expect.

This happens in _extent2dims

[rafaqz]

We need extents.jl to have closed or open intervals.

We currently have to hack a tiny pad in so closed intervals of e.g. a Multipoint is not cut off in the open high edge of a raster. R does this too

[tiemvanderdeure]

Fixed now!

julia> using Rasters, Extents

julia> extr =Extent(X=(-1,1.1), Y=(0.33,2));

julia> rasr = rasterize((1,1), to=extr, res=0.1, fill=1, reducer=sum)
┌ 22×17 Raster{Union{Missing, Int64}, 2} nothing ┐
├────────────────────────────────────────────────┴─────────────────────────────────────────────────────────────────────────────────────────────────────────── dims ┐       
  ↓ X Projected{Float64} -1.0:0.1:1.1 ForwardOrdered Regular Intervals{Start},
  → Y Projected{Float64} 0.33:0.1:1.93 ForwardOrdered Regular Intervals{Start}
├──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────── metadata ┤       
  Metadata of Dict{Any, Any}()
├────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────── raster ┤       
  extent: Extent(X = (-1.0, 1.2000000000000002), Y = (0.33, 2.03))
  missingval: missing
└──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘       
 ↓ →  0.33      0.43      0.53      0.63      0.73      0.83      0.93      1.03      …  1.23      1.33      1.43      1.53      1.63      1.73      1.83      1.93
 ⋮                                            ⋮                                       ⋱  ⋮                                                 ⋮
 1.1   missing   missing   missing   missing   missing   missing   missing   missing      missing   missing   missing   missing   missing   missing   missing   missing    

The open-closed interval thing is a separate issue, I think we can close this one