Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

endpoint to reload config #276

Open
piif opened this issue Oct 8, 2024 · 1 comment
Open

endpoint to reload config #276

piif opened this issue Oct 8, 2024 · 1 comment
Labels

Comments

@piif
Copy link

piif commented Oct 8, 2024

Is your feature request related to a problem? Please describe

I'd like to be able to change some mongo queries in configuration without having to restart the exporter

Describe the solution you'd like

A endpoint like /reload may force to reload configurations file, thus if configuration is read from a mounted config map folder, changes in those config maps could be taken into account by the exporter

Describe alternatives you've considered

Alternative is to restart pod, or at least kill its main process, but it may loose counters and cache

@raffis
Copy link
Owner

raffis commented Oct 21, 2024

How is restarting the process an actual problem? Loosing counters isn't and you always have to factor in a possible restart of a process.
Also its gauges anyways, you will get the same metrics after the restart.
The only real advantage is not loosing a query cache but I don't think so its worth supporting this only because of that.

@github-actions github-actions bot added the Stale label Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants