-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mergo Related Build issues #540
Comments
Assigned @jbiers to work on part 1 of the issue. I'm not sure the best way to do task 2 though; so we won't rush that idea. Alternatively, you could also make a new issue to split out the Renovate change (mainly for tracking your work since it doesn't require QA). |
The immediate solution was implemented in PR #542 |
Proper fix is blocked until there are upstream changes. |
Update on upstream changes concerns; k8s group confirmed they plan to remove the library. PRs to remove it are in progress and once they do merge those we can adjust wrangler accordingly and BRO after that. |
Upstream k8s has removed mergo as of this PR kubernetes/kubernetes#126764 |
I've closed the wrangler issue I created as this is an issue I suspect will naturally resolve itself once we are working on Rancher 2.11 (i.e. adding 1.32 k8s support). Since the upstream go code removes the library in 1.32 k8s. For now I'll leave this open as tech debt simply to remind us to clean up the renovate config around when that happens. |
Describe the bug
We reverted bumps to mergo due to it causing build issues: #539
Then I dug deeper and found k8s long standing issue about this topic here: kubernetes/kubernetes#107499
At minimum BRO repo needs to adjust renovate to ignore the package.
Maybe we consider reverting the mergo pin to use
v0.3.5
like the k8s issue says.That in mind, there are two (and a half) portions to fixing this issue:
2.5 Consider Being the BEST FOSS community members: Do we dare consider to go fix the root issues behind this 2-3+ year long issue? Would first need to be fixed at mergo package, then they would (in theory) cut a
v1.0.1
thenkubernetes
repo needs to be updated. THEN finally we as Rancher can update Wrangler and stuff.The text was updated successfully, but these errors were encountered: