Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport v2.10.3] [BUG] Settings page does not handle errors anymore from Rancher version 2.10 #13183

Open
github-actions bot opened this issue Jan 23, 2025 · 0 comments
Assignees
Labels
JIRA kind/bug priority/0 QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this QA/None regression status/backport-candidate
Milestone

Comments

@github-actions
Copy link
Contributor

This is a backport issue for #13163, automatically created via GitHub Actions workflow initiated by @torchiaf

Original issue body:

SURE-9650

Rancher Server Setup

  • Rancher version: 2.10.1
  • Installation option (Docker install/Helm Chart):
    • Helm Chart on Kubernetes v1.28.2

User Information

  • What is the role of the user logged in? (Admin/Cluster Owner/Cluster Member/Project Owner/Project Member/Custom)
    • If custom, define the set of permissions: Restricted Admin

Describe the bug
Hello,

We spotted that there is a regression in the error handling in Rancher dashboard settings page.
Indeed, we have a webhook preventing customers to modify some critical settings (not all).
In v2.9.7 when the webhook returned an error, the error was display in an error banner:

Image

But in version 2.10.1, the error is never displayed. Only the save button becomes red:

Image

To Reproduce

  • Install a webhook in Rancher namespace preventing settings modifications
  • Modify a setting

Result

Expected Result
The error message is displayed in a red banner in the top of the page

Screenshots
See in text

Additional context
It relates to issue #9183 but it's a bit different because in our case, it worked in previous Rancher minor version (2.9) while it never worked on the driver page side.

Thanks,
Best Regards,
Thomas

@github-actions github-actions bot added JIRA kind/bug priority/0 QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this QA/None regression status/backport-candidate labels Jan 23, 2025
@github-actions github-actions bot added this to the v2.10.2 milestone Jan 23, 2025
@torchiaf torchiaf modified the milestones: v2.10.2, v2.10.3 Jan 23, 2025
@torchiaf torchiaf changed the title [backport v2.10.2] [BUG] Settings page does not handle errors anymore from Rancher version 2.10 [backport v2.10.3] [BUG] Settings page does not handle errors anymore from Rancher version 2.10 Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JIRA kind/bug priority/0 QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this QA/None regression status/backport-candidate
Projects
None yet
Development

No branches or pull requests

1 participant