From db9182eae83f87a84e83465715101eefe262cd9a Mon Sep 17 00:00:00 2001 From: Jimmy Hoenderdaal Date: Fri, 20 Dec 2024 08:56:17 +0100 Subject: [PATCH 1/6] Changed review stars to blade --- README.md | 5 ++- resources/js/components.js | 4 -- resources/js/components/StarInput.vue | 31 ---------------- resources/js/components/Stars.vue | 43 ---------------------- resources/js/package.js | 1 - resources/views/components/stars.blade.php | 32 ++++++++++++++++ resources/views/form.blade.php | 42 ++++++++++++--------- resources/views/reviews.blade.php | 4 +- 8 files changed, 62 insertions(+), 100 deletions(-) delete mode 100644 resources/js/components.js delete mode 100644 resources/js/components/StarInput.vue delete mode 100644 resources/js/components/Stars.vue delete mode 100644 resources/js/package.js create mode 100644 resources/views/components/stars.blade.php diff --git a/README.md b/README.md index 97264d7..6e57324 100644 --- a/README.md +++ b/README.md @@ -24,7 +24,7 @@ If you'd like to show product reviews on out-of-stock product pages you need to Add the stars where you'd like in `resources/views/vendor/rapidez/product/overview.blade.php`: ```blade @if($product->reviews_score) - + @endif ``` @@ -54,7 +54,8 @@ And the form to add a review: Add somewhere in `resources/views/category/partials/listing/item.blade.php`: ```blade - + + ``` ## Views diff --git a/resources/js/components.js b/resources/js/components.js deleted file mode 100644 index 3cca1fe..0000000 --- a/resources/js/components.js +++ /dev/null @@ -1,4 +0,0 @@ -import 'Vendor/rapidez/core/resources/js/vue' - -Vue.component('star-input', () => import('./components/StarInput.vue')) -Vue.component('stars', () => import('./components/Stars.vue')) \ No newline at end of file diff --git a/resources/js/components/StarInput.vue b/resources/js/components/StarInput.vue deleted file mode 100644 index 31f19cf..0000000 --- a/resources/js/components/StarInput.vue +++ /dev/null @@ -1,31 +0,0 @@ - diff --git a/resources/js/components/Stars.vue b/resources/js/components/Stars.vue deleted file mode 100644 index bf7cd66..0000000 --- a/resources/js/components/Stars.vue +++ /dev/null @@ -1,43 +0,0 @@ - - diff --git a/resources/js/package.js b/resources/js/package.js deleted file mode 100644 index ebb2fb0..0000000 --- a/resources/js/package.js +++ /dev/null @@ -1 +0,0 @@ -import './components' \ No newline at end of file diff --git a/resources/views/components/stars.blade.php b/resources/views/components/stars.blade.php new file mode 100644 index 0000000..6206266 --- /dev/null +++ b/resources/views/components/stars.blade.php @@ -0,0 +1,32 @@ +@props(['score' => 0, 'count' => null]) + +
twMerge('flex items-center gap-1') }}> +
+
+ @for ($star = 0; $star < 5; $star++) + + @endfor +
+
has('v-bind:score')) + v-bind:style="{ width: ({{ $attributes['v-bind:score'] }} || 0) + '%'}" + @endif + class="absolute inset-0 flex gap-0.5 overflow-hidden" + > + @for ($star = 0; $star < 5; $star++) + + @endfor +
+
+ has('v-bind:count')) + v-text="'(' + ({{ $attributes['v-bind:count'] }} || 0) + ')'" + @endif + > + @if ($count) + ({{ $count }}) + @endif + +
diff --git a/resources/views/form.blade.php b/resources/views/form.blade.php index e0626df..df88307 100644 --- a/resources/views/form.blade.php +++ b/resources/views/form.blade.php @@ -13,26 +13,34 @@
-
-
+
+
@{{ rating.name }} - -
- -
-
+
+ +
-
- @lang('Rating') -
- @for ($i = 0; $i < 5; $i++) - - @endfor -
+
+ @lang('Rating') * +
diff --git a/resources/views/reviews.blade.php b/resources/views/reviews.blade.php index 7b16b80..c3d78f6 100644 --- a/resources/views/reviews.blade.php +++ b/resources/views/reviews.blade.php @@ -15,7 +15,7 @@
- +
@{{ review.summary }}

@{{ review.text }}

@@ -31,7 +31,7 @@ @{{ new Date(Date.now()).toLocaleDateString() }}
- + @lang('Be the first to write a review') From 29d036627161a9aad9fd2560540d2a1418ddb470 Mon Sep 17 00:00:00 2001 From: Jimmy Hoenderdaal Date: Fri, 20 Dec 2024 09:32:20 +0100 Subject: [PATCH 2/6] Update colors --- resources/views/components/stars.blade.php | 22 +++++++++++----------- resources/views/form.blade.php | 4 ++-- 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/resources/views/components/stars.blade.php b/resources/views/components/stars.blade.php index 6206266..090bef8 100644 --- a/resources/views/components/stars.blade.php +++ b/resources/views/components/stars.blade.php @@ -4,7 +4,7 @@
@for ($star = 0; $star < 5; $star++) - + @endfor
@for ($star = 0; $star < 5; $star++) - + @endfor
- has('v-bind:count')) - v-text="'(' + ({{ $attributes['v-bind:count'] }} || 0) + ')'" - @endif - > - @if ($count) + @if ($count || $attributes->has('v-bind:count')) + has('v-bind:count')) + v-text="'(' + ({{ $attributes['v-bind:count'] }} || 0) + ')'" + @endif + > ({{ $count }}) - @endif - + + @endif
diff --git a/resources/views/form.blade.php b/resources/views/form.blade.php index df88307..fa21ab3 100644 --- a/resources/views/form.blade.php +++ b/resources/views/form.blade.php @@ -19,9 +19,9 @@
has('v-bind:score')) - v-bind:style="{ width: ({{ $attributes['v-bind:score'] }} || 0) + '%'}" - @endif + style="width: {{ (int)$score }}%" + v-bind:style="{ width: ({{ $score }} || 0) + '%'}" class="absolute inset-0 flex gap-0.5 overflow-hidden" > @for ($star = 0; $star < 5; $star++) From c77de638a394b6b7110036ffa776b22c3140705b Mon Sep 17 00:00:00 2001 From: Jimmy Hoenderdaal Date: Wed, 15 Jan 2025 14:55:19 +0100 Subject: [PATCH 4/6] Simplify score and count binding --- resources/views/components/stars.blade.php | 13 ++++--------- resources/views/reviews.blade.php | 2 +- 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/resources/views/components/stars.blade.php b/resources/views/components/stars.blade.php index 6eaa492..b83656f 100644 --- a/resources/views/components/stars.blade.php +++ b/resources/views/components/stars.blade.php @@ -4,12 +4,12 @@
@for ($star = 0; $star < 5; $star++) - + @endfor
@for ($star = 0; $star < 5; $star++) @@ -17,13 +17,8 @@ class="absolute inset-0 flex gap-0.5 overflow-hidden" @endfor
- @if ($count || $attributes->has('v-bind:count')) - has('v-bind:count')) - v-text="'(' + ({{ $attributes['v-bind:count'] }} || 0) + ')'" - @endif - > + @if ($count) + ({{ $count }}) @endif diff --git a/resources/views/reviews.blade.php b/resources/views/reviews.blade.php index c3d78f6..7197b41 100644 --- a/resources/views/reviews.blade.php +++ b/resources/views/reviews.blade.php @@ -15,7 +15,7 @@
- +
@{{ review.summary }}

@{{ review.text }}

From 83461c5cf5c6db0e0bf9ce661839e90e7d964d0c Mon Sep 17 00:00:00 2001 From: Jimmy Hoenderdaal Date: Wed, 15 Jan 2025 15:40:05 +0100 Subject: [PATCH 5/6] Cast $score and $count to int --- resources/views/components/stars.blade.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/resources/views/components/stars.blade.php b/resources/views/components/stars.blade.php index b83656f..3a8636c 100644 --- a/resources/views/components/stars.blade.php +++ b/resources/views/components/stars.blade.php @@ -9,7 +9,7 @@
@for ($star = 0; $star < 5; $star++) @@ -19,7 +19,7 @@ class="absolute inset-0 flex gap-0.5 overflow-hidden"
@if ($count) - ({{ $count }}) + ({{ (int)$count }}) @endif
From afb75a45436ce1554d6d41e368021af58fd2b98f Mon Sep 17 00:00:00 2001 From: Jimmy Hoenderdaal Date: Wed, 15 Jan 2025 15:49:02 +0100 Subject: [PATCH 6/6] Update readme and change v-cloak position --- README.md | 2 +- resources/views/form.blade.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 6e57324..2c423f4 100644 --- a/README.md +++ b/README.md @@ -54,7 +54,7 @@ And the form to add a review: Add somewhere in `resources/views/category/partials/listing/item.blade.php`: ```blade - + ``` diff --git a/resources/views/form.blade.php b/resources/views/form.blade.php index fa21ab3..e8cd599 100644 --- a/resources/views/form.blade.php +++ b/resources/views/form.blade.php @@ -62,7 +62,7 @@ class="sr-only" @lang('Submit Review') - + @lang('You submitted your review for moderation.')