Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4 compatibility issues #161

Open
stonie1989 opened this issue Dec 13, 2024 · 3 comments
Open

PHP 8.4 compatibility issues #161

stonie1989 opened this issue Dec 13, 2024 · 3 comments

Comments

@stonie1989
Copy link

stonie1989 commented Dec 13, 2024

Are there plans to make Pawl fully compatible to PHP 8.4?
Currently there are some deprecation warnings regarding the Client connect() function.

Deprecated: Ratchet\Client\connect(): Implicitly marking parameter $loop as nullable is deprecated, the explicit nullable type must be used instead in vendor/ratchet/pawl/src/functions.php on line 12 PHP Deprecated: Ratchet\Client\connect(): Implicitly marking parameter $loop as nullable is deprecated, the explicit nullable type must be used instead in vendor/ratchet/pawl/src/functions.php on line 12

Edit:
Would be a very simple change in one line:

From

function connect($url, array $subProtocols = [], $headers = [], LoopInterface $loop = null) {
    $connector = new Connector($loop);
    $connection = $connector($url, $subProtocols, $headers);

    return $connection;
}

To:

function connect($url, array $subProtocols = [], $headers = [], LoopInterface|null $loop = null) {
    $connector = new Connector($loop);
    $connection = $connector($url, $subProtocols, $headers);

    return $connection;
}
@taylorvance
Copy link

taylorvance commented Dec 17, 2024

I have a pull request to fix this.

e: later noticed there was already a PR for this issue

@ZalakNHirani
Copy link

I am facing the same issue. When are you planning to give fix for this?

@shehi
Copy link

shehi commented Jan 8, 2025

Is this repo even alive?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants