Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chgcentre path is hardwired #37

Open
IanHeywood opened this issue Jan 19, 2025 · 1 comment
Open

chgcentre path is hardwired #37

IanHeywood opened this issue Jan 19, 2025 · 1 comment

Comments

@IanHeywood
Copy link
Collaborator

The chgcentre executable is hardwired in solarkat.py, so it crashes when the executable isn't found:

chgcentre_path= '/home/samboco/solarKAT/Git_clone/wsclean/build/chgcentre'

I notice that cult-cargo builds chgcentre as part of the wsclean Docker container, but AFAIK the inputs to it won't be mapped as there is no dedicated chgcentre yaml to map them. I'm not sure what the best way to proceed here is since solarkat will call its own custom cab to shift the per-scan MS coordinates to the Sun, which involves opening a text file. A cleaner implementation might be to have a chgcentre cab (either custom or added to cult-cargo) and then implement that directly in the solarkat.yaml recipe. However I don't know if that's possible since it has to read the text file...

@o-smirnov
Copy link
Collaborator

A cleaner implementation might be to have a chgcentre cab (either custom or added to cult-cargo) and then implement that directly in the solarkat.yaml recipe

Yup, exactly. My preferred workflow is do a custom cab in place, test it, then make a PR into cult-cargo to make it "official".

The text file is just begging for a for_loop implementation. I have an example I haven't checked in yet (/net/home/oms/JoveS/jove-prepare.yml)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants