-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade to python 3 #20
Comments
I guess just as a quick followup I switched over to https://registry.terraform.io/modules/terraform-aws-modules/lambda/aws/latest instead of this package and found that it was more up to date and feature compatible for my use cases incase it helps anyone else. |
Thanks, I'll have to read PEP 394 and see what makes sense. The actual Python code used in this module is compatible with Python 2 and 3 so I'd prefer to support both if it's not difficult. The main reason one might use this module over https://registry.terraform.io/modules/terraform-aws-modules/lambda/aws/latest is that this module doesn't require any of the build toolchain (pip/npm/go/etc) or Docker to be available on the machine running Terraform. The Lambda package gets built inside a Lambda or CodeBuild environment. |
Python 2 is very dead so I'd argue against trying to continue supporting it. Regardless, the pep basically calls out that |
We just had this issue on Terraform Cloud. Fixed by changing Happy to raise PRs for the fixes, but I'm unsure if the module should retain backwards compatibility with the python 2 executable. Thoughts? |
Current module does not work any longer on macOS 12.3 which removed the
python
command. Need to update to usepython3
which should work universally across most systems via PEP 394.The text was updated successfully, but these errors were encountered: