Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow additional roles for BQ provider #317

Closed
wants to merge 4 commits into from
Closed

feat: allow additional roles for BQ provider #317

wants to merge 4 commits into from

Conversation

singhvikash11
Copy link
Member

No description provided.

@vercel
Copy link

vercel bot commented Nov 3, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
guardian ✅ Ready (Inspect) Visit Preview Nov 10, 2022 at 8:30AM (UTC)

@coveralls
Copy link

coveralls commented Nov 3, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3757076510

  • 16 of 59 (27.12%) changed or added relevant lines in 4 files are covered.
  • 450 unchanged lines in 12 files lost coverage.
  • Overall coverage decreased (-0.05%) to 74.605%
Changes Missing Coverage Covered Lines Changed/Added Lines %
plugins/providers/bigquery/config.go 8 10 80.0%
plugins/providers/bigquery/provider.go 0 12 0.0%
plugins/providers/bigquery/model.go 0 14 0.0%
plugins/providers/bigquery/client.go 8 23 34.78%
Files with Coverage Reduction New Missed Lines %
api/handler/v1beta1/grpc.go 1 91.3%
core/approval/service.go 3 85.71%
api/handler/v1beta1/provider.go 4 96.33%
plugins/providers/gcloudiam/config.go 5 91.53%
api/handler/v1beta1/policy.go 12 78.75%
plugins/providers/gcloudiam/provider.go 23 80.95%
core/grant/service.go 34 10.14%
plugins/providers/gcloudiam/client.go 45 7.1%
core/policy/service.go 46 62.55%
core/provider/service.go 69 77.24%
Totals Coverage Status
Change from base Build 3358523652: -0.05%
Covered Lines: 6801
Relevant Lines: 9116
💛 - Coveralls

@ravisuhag ravisuhag changed the title fix: fix issue https://github.com/odpf/guardian/issues/316 fix: fix issue 316 Nov 4, 2022
@ravisuhag ravisuhag linked an issue Nov 4, 2022 that may be closed by this pull request
Only allowed a few roles on Bigquery Dataset #316
Open
@ravisuhag ravisuhag changed the title fix: fix issue 316 feat: allow additional roles for BQ provider Nov 4, 2022
@singhvikash11
chore: handle following permission inter-changeable:
e6aed37 
reader <-> roles/bigquery.dataViewer, owner <-> roles/bigquery.dataOwner, editor <-> roles/bigquery.dataEditor
rahmatrhd
rahmatrhd requested changes Dec 15, 2022
View reviewed changes
plugins/providers/bigquery/provider.go Show resolved Hide resolved
plugins/providers/bigquery/client.go Outdated Show resolved Hide resolved
plugins/providers/bigquery/client.go Outdated Show resolved Hide resolved
plugins/providers/bigquery/client.go Outdated Show resolved Hide resolved
plugins/providers/bigquery/client.go Show resolved Hide resolved
@singhvikash11
Copy link
Member Author

@rahmatrhd @mabdh @bsushmith please review and approve

@singhvikash11
Copy link
Member Author

@rahmatrhd let's close this pr, I guess you already fixed it by
getGcloudPermissions
translateDatasetRoleToBigQueryRole

@ravisuhag ravisuhag deleted the fix_bq_dataset_role branch January 4, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravisuhag ravisuhag Awaiting requested review from ravisuhag ravisuhag is a code owner

@AkarshSatija AkarshSatija Awaiting requested review from AkarshSatija AkarshSatija is a code owner

@bsushmith bsushmith Awaiting requested review from bsushmith bsushmith is a code owner

@mabdh mabdh Awaiting requested review from mabdh mabdh is a code owner

@haveiss haveiss Awaiting requested review from haveiss

@rahmatrhd rahmatrhd Awaiting requested review from rahmatrhd rahmatrhd is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Only allowed a few roles on Bigquery Dataset
5 participants
@singhvikash11 @coveralls @mabdh @rahmatrhd @bsushmith