Conflicts with iTerm2 shell integration. #21
Comments
|
See my comment in #6 |
rcaloras
added a commit
that referenced
this issue
Apr 18, 2016
- Invoke our install as part of PROMPT_COMMAND. This allows bash-preexec to be included at any point in our configuration and it should be invoked last. This makes sure we always have access to the DEBUG trap and that PROMPT_COMMAND is most likely untampered with. - Should adress #21 and the occasional issue that gets created because bash-preexec is included improperly.
Merged
rcaloras
added a commit
that referenced
this issue
Apr 18, 2016
- Invoke our install as part of PROMPT_COMMAND. This allows bash-preexec to be included at any point in our configuration and it should be invoked last. This makes sure we always have access to the DEBUG trap and that PROMPT_COMMAND is most likely untampered with. - Should adress #21 and the occasional issue that gets created because bash-preexec is included improperly.
rcaloras
added a commit
that referenced
this issue
Apr 18, 2016
- Invoke our install as part of PROMPT_COMMAND. This allows bash-preexec to be included at any point in our configuration and it should be invoked last. This makes sure we always have access to the DEBUG trap and that PROMPT_COMMAND is most likely untampered with. - Should adress #21 and the occasional issue that gets created because bash-preexec is included improperly.
rcaloras
added a commit
that referenced
this issue
Apr 18, 2016
- Invoke our install as part of PROMPT_COMMAND. This allows bash-preexec to be included at any point in our configuration and it should be invoked last. This makes sure we always have access to the DEBUG trap and that PROMPT_COMMAND is most likely untampered with. - Should adress #21 and the occasional issue that gets created because bash-preexec is included improperly.
rcaloras
added a commit
that referenced
this issue
Apr 22, 2016
- Invoke our install as part of PROMPT_COMMAND. This allows bash-preexec to be included at any point in our configuration and it should be invoked last. This makes sure we always have access to the DEBUG trap and that PROMPT_COMMAND is most likely untampered with. - Should adress #21 and the occasional issue that gets created because bash-preexec is included improperly.
rcaloras
added a commit
that referenced
this issue
Apr 22, 2016
- Invoke our install as part of PROMPT_COMMAND. This allows bash-preexec to be included at any point in our configuration and it should be invoked last. This makes sure we always have access to the DEBUG trap and that PROMPT_COMMAND is most likely untampered with. - Should adress #21 and the occasional issue that gets created because bash-preexec is included improperly.
|
Fixed in 0.3.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Causes: rcaloras/bashhub-client#27
Looks like both projects leverage the debug trap to create a preexec function. @gnachman any chance you could be convinced to use this library if it can provide everything you need for iTerm2's preexec functionality? I'm happy to make all the PRs :) I want to make sure Bashhub and iTerm2 can work together.
Quoted from #6
I'd love to fix up this project to make it compatible with the awesome iTerm2 :) I wrote bash-preexec to include function arrays and to avoid multiple inclusion which allows multiple shell integrations to add preexec functions triggered through one debug trap hook. Any chance you'd be willing to switch to this library if I make it compatible?
Thanks!
The text was updated successfully, but these errors were encountered: