Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the E12 team to open and close submission to cohorts #1166

Open
mbarton opened this issue Jan 14, 2025 · 0 comments
Open

Allow the E12 team to open and close submission to cohorts #1166

mbarton opened this issue Jan 14, 2025 · 0 comments
Labels
priority: medium Medium Priority Work - No Max Item Limit

Comments

@mbarton
Copy link
Member

mbarton commented Jan 14, 2025

We have had to do two hot fixes due to the platform disabling data submission automatically:

It's undesirable for both ourselves in the development team and the E12 audit team for the platform to close off submissions automatically. Even now we are reasonably confident our logic is correct, it's perfectly reasonable for the E12 team to extend the submission grace period as they see fit.

This issue is to refit the platform to allow the E12 team to open and close submission to cohorts. On a code level, this means we need to check everywhere that restricts actions based on date or cohort number. The submission start end dates should become content managed - the actual code restricting actions should not have any idea what a grace period is, even if we display both the normal end date and the grace period end date in the summary UI.

Note the organisational audit already has an OrganisationalAuditSubmissionPeriod which works in this way. I think it makes sense to have separate open/close for the different types of audit. So probably an additional model rather than trying to re-purpose the existing one? Or at least a type enum field on the existing model.

As part of this work it makes sense to review any remaining hard coded cohorts, eg #1122 and fix related bugs (eg #1176)

@mbarton mbarton added priority: high High Priority Work - Max 3 Items and removed priority: high High Priority Work - Max 3 Items labels Jan 14, 2025
@mbarton mbarton added the priority: medium Medium Priority Work - No Max Item Limit label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: medium Medium Priority Work - No Max Item Limit
Projects
None yet
Development

No branches or pull requests

1 participant