Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Falafel uses outdated acorn, which introduces Content Security issues #185

Open
salemhilal opened this issue Feb 15, 2016 · 1 comment
Open

Comments

@salemhilal
Copy link
Contributor

TL;DR: Either falafel needs to use a newer version of acorn, or an alternative may need to be found.

I (half-actively) maintain a jsfmt plugin for Atom. I started getting issues about a Content Security Policy violation from my package. I tracked the issue down to an old version of acorn, used by falafel, that has new Function calls. For a while, acorn provided a pre-compiled distribution to get around this, but they've since fixed this problem entirely.

It seems like Falafel may not be being actively maintained anymore. On the other hand, I'm not sure it's a huge issue unless you're trying to require('jsfmt').

@ariya
Copy link
Contributor

ariya commented Mar 3, 2016

An alternative approach is to not use falafel at all. I spot that falafel is being used only inside lib/rewrite.js. Most of the logic has been implemented already there and that file is longer that the core of falafel. It does not add too much complexity to incorporate a simplistic (but sufficient) tree traversal within lib/rewrite.js itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants