Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dsAudio - Issue in test case dsAudio_negative_dsGetMS12AudioProfile #283

Open
bhanucbp opened this issue Jan 27, 2025 · 0 comments · May be fixed by #290
Open

dsAudio - Issue in test case dsAudio_negative_dsGetMS12AudioProfile #283

bhanucbp opened this issue Jan 27, 2025 · 0 comments · May be fixed by #290
Assignees
Labels
bug Something isn't working

Comments

@bhanucbp
Copy link
Contributor

bhanucbp commented Jan 27, 2025

Problem/Opportunity

  • In test case test_l1_dsAudio_negative_dsGetMS12AudioProfile(void), for the below negative scenario - Attempt to get MS12 Audio Profile with a null pointer dsGetMS12AudioProfile funtion is only called when gDSAudioPortConfiguration[i].ms12_audioprofilecount has value and not called in else case :

      // Step 05: Attempt to get MS12 Audio Profile with a null pointer
      if ((gSourceType == 0) && (gDSAudioPortConfiguration[i].ms12_audioprofilecount))
      {
          result = dsGetMS12AudioProfile(handle, NULL);
          UT_ASSERT_EQUAL(result, dsERR_INVALID_PARAM);
      }
      else
      {
          UT_ASSERT_EQUAL(result, dsERR_OPERATION_NOT_SUPPORTED);
      } 
    
  • test case test_l1_dsAudio_positive_dsGetMS12AudioProfile:
    memcmp return value should be compared with 0 value not with the size

     result = dsGetMS12AudioProfileList(handle, &profileList1);
     if (gSourceType == 0)
     {
         UT_ASSERT_EQUAL(result, dsERR_NONE);
         // Step 04: Get the list of supported MS12 audio profiles for each port in new array
         result = dsGetMS12AudioProfileList(handle, &profileList2);
         UT_ASSERT_EQUAL(result, dsERR_NONE);
         // Step 05: compare the values of profileList arrays
         result = memcmp(profileList1.audioProfileList, profileList2.audioProfileList, sizeof(profileList1.audioProfileList));
         **UT_ASSERT_EQUAL(result, sizeof(profileList1));**
     }
    

Steps to reproduce

No response

Expected Behavior

Actual Behavior

Notes (Optional)

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
2 participants