Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Props 'distanceToChangeTab' is useless when 'usePaged' and 'swipeable' is set true. #76

Open
sqhtiamo opened this issue Mar 22, 2019 · 0 comments

Comments

@sqhtiamo
Copy link

sqhtiamo commented Mar 22, 2019

Props 'distanceToChangeTab' is useless when 'usePaged' and 'swipeable' is set true.

If onSwipe is triggered, then it will call 'goToTab' function. Like,
https://github.com/react-component/m-tabs/blob/master/src/Tabs.tsx#L154.

Well, in 'https://github.com/react-component/m-tabs/blob/master/src/Tabs.tsx#L263',
whether 'onSwipe' triggered is decided by Gesture Component.

export function shouldTriggerSwipe(delta, velocity) {
  `return` Math.abs(delta) >= SWIPE.threshold && Math.abs(velocity) > SWIPE.velocity;
}
`
...
export const SWIPE = {
  threshold: 10,
  velocity: 0.3,
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant