Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4 deprecations require reactphp/promise breaking changes #265

Closed
glo71317 opened this issue Dec 14, 2024 · 1 comment
Closed

PHP 8.4 deprecations require reactphp/promise breaking changes #265

glo71317 opened this issue Dec 14, 2024 · 1 comment
Labels

Comments

@glo71317
Copy link

Addressing PHP 8.4 Deprecations:

With the release of PHP 8.4, several deprecations and breaking changes have been introduced that may require attention in order to ensure continued compatibility and avoid potential issues. We are keen to address these changes and adapt our codebase to fully support PHP 8.4 without introducing any breaking changes for our users.

Some of the key deprecations to be aware of include:

  1. Implicitly marking parameter $onRejected as nullable is deprecated: The explicit nullable type must be used instead.
  2. Deprecation of the E_STRICT constant: This constant is no longer supported in PHP 8.4.
  3. session_set_save_handler() with more than two arguments: This usage is now deprecated in PHP 8.4.

We would like to inquire if there is a plan to address these deprecations in the near future and would be more than happy to contribute to this effort. By collaborating, we can help ensure that the transition to PHP 8.4 is as smooth as possible for all users and avoid any disruptions caused by these changes.

Please let us know how we can assist in this process, and if there are any specific steps we should follow to contribute towards the resolution of these issues.

Looking forward to your response.

Deprecated: React\Promise\Internal\FulfilledPromise::then(): Implicitly marking parameter $onFulfilled as nullable is deprecated, the explicit nullable type must be used instead in phar:///usr/bin/composer/vendor/react/promise/src/Internal/FulfilledPromise.php on line 37
Deprecated: React\Promise\Internal\FulfilledPromise::then(): Implicitly marking parameter $onRejected as nullable is deprecated, the explicit nullable type must be used instead in phar:///usr/bin/composer/vendor/react/promise/src/Internal/FulfilledPromise.php on PHP Deprecated:  React\Promise\Promise::__construct(): Implicitly marking parameter $canceller as nullable is deprecated, the explicit nullable type must be used instead in phar:///usr/bin/composer/vendor/react/promise/src/Promise.php on line 32
PHP Deprecated:  React\Promise\Promise::then(): Implicitly marking parameter $onFulfilled as nullable is deprecated, the explicit nullable type must be used instead in phar:///usr/bin/composer/vendor/react/promise/src/Promise.php on line 44
PHP Deprecated:  React\Promise\Promise::then(): Implicitly marking parameter $onRejected as nullable is deprecated, the explicit nullable type must be used instead in phar:///usr/bin/composer/vendor/react/promise/src/Promise.php on line 44
Deprecated: React\Promise\Promise::__construct(): Implicitly marking parameter $canceller as nullable is deprecated, the explicit nullable type must be used instead in phar:///usr/bin/composer/vendor/react/promise/src/Promise.php on line 32
Deprecated: React\Promise\Promise::then(): Implicitly marking parameter $onFulfilled as nullable is deprecated, the explicit nullable type must be used instead in phar:///usr/bin/composer/vendor/react/promise/src/Promise.php on line 44
Deprecated: React\Promise\Promise::then(): Implicitly marking parameter $onRejected as nullable is deprecated, the explicit nullable type must be used instead in phar:///usr/bin/composer/vendor/react/promise/src/Promise.php on line 44
Deprecated: React\Promise\Promise::resolver(): Implicitly marking parameter $onFulfilled as nullable is deprecated, the explicit nullable type must be used instead in phar:///usr/bin/composer/vendor/react/promise/src/Promise.php on line 169
Deprecated: React\Promise\Promise::resolver(): Implicitly marking parameter $onRejected as nullable is deprecated, the explicit nullable type must be used instead in phar:///usr/bin/composer/vendor/react/promise/src/Promise.php on line 169
PHP Deprecated:  React\Promise\Promise::resolver(): Implicitly marking parameter $onFulfilled as nullable is deprecated, the explicit nullable type must be used instead in phar:///usr/bin/composer/vendor/react/promise/src/Promise.php on line 169
PHP Deprecated:  React\Promise\Promise::resolver(): Implicitly marking parameter $onRejected as nullable is deprecated, the explicit nullable type must be used instead in phar:///usr/bin/composer/vendor/react/promise/src/Promise.php on line 169
@glo71317 glo71317 added the bug label Dec 14, 2024
@clue clue added invalid and removed bug labels Dec 14, 2024
@clue
Copy link
Member

clue commented Dec 14, 2024

We have you covered already from day one, it looks like you're using an outdated version, please update to the latest version first.

Closing as duplicate of https://github.com/orgs/reactphp/discussions/589 and #260.

I hope this helps! 👍 If so, consider supporting this project, for example by becoming a sponsor ❤️

@clue clue closed this as not planned Won't fix, can't repro, duplicate, stale Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants