Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rabbitmq-dotnet-client 6.1 crashes rebus at startup #69

Closed
mathiasnohall opened this issue Jun 7, 2020 · 10 comments
Closed

rabbitmq-dotnet-client 6.1 crashes rebus at startup #69

mathiasnohall opened this issue Jun 7, 2020 · 10 comments

Comments

@mathiasnohall
Copy link
Contributor

mathiasnohall commented Jun 7, 2020

using the new version of dotnet rabbitMQ client 6.1.0 seems to make rebus crash at startup in an MVC ASPNET Core 3.1 application.

Rebus.Injection.ResolutionException: 'Could not resolve Rebus.RabbitMq.RabbitMqTransport with decorator depth 0 - registrations: Rebus.Injection.Injectionist+Handler'

TypeLoadException: Could not load type 'RabbitMQ.Client.IQueueingBasicConsumer' from assembly 'RabbitMQ.Client, Version=6.0.0.0, Culture=neutral, PublicKeyToken=89e7d7c5feba84ce'.

using Rebus 6.3.0 and Rebus.RabbitMq 7.1.0

@mookid8000
Copy link
Member

Sounds like Rebus.RabbitMq needs to have its RabbitMq.Client dependency updated.

@mookid8000
Copy link
Member

OK, work is ongoing in making Rebus.RabbitMq work with version 6.1 of the driver.

Many of the tests are passing now, but some of them experience weird errors that indicates having received some kind of mangled message body.

Gonna park it for now – most recent code is on master.

@Ilya-by
Copy link

Ilya-by commented Aug 28, 2020

Gonna park it for now

any news on updating the client driver version?

@mookid8000
Copy link
Member

oh, it's been a long time since I've looked at it.... I'll see if I can get back to this in the coming week

@archimate
Copy link

waiting。。。

@wzychla
Copy link

wzychla commented Oct 15, 2020

Bumping this.

@mathiasnohall
Copy link
Contributor Author

#71

solves this. I have tested it in our code enviroment and it works. Some unit tests in Rebus.RabbitMq.Tests are failing though

@mookid8000
Copy link
Member

Ok cool! I'll have time to look at it on Friday

@mathiasnohall
Copy link
Contributor Author

ok there seem to be some issue with the internal queue in CustomQueueingConsumer.cs. If I change it from a ConcurrentQueue to the old SharedQueue from https://github.com/rabbitmq/rabbitmq-dotnet-client/blob/5.x/projects/client/RabbitMQ.Client/src/util/SharedQueue.cs it seems to work better. Only 1 test is failing now..

@mookid8000
Copy link
Member

Should be fixed by #71 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants