Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publisher confirms should be sent in batch #771

Closed
kyrrem opened this issue Jan 29, 2019 · 2 comments
Closed

Publisher confirms should be sent in batch #771

kyrrem opened this issue Jan 29, 2019 · 2 comments

Comments

@kyrrem
Copy link

kyrrem commented Jan 29, 2019

When sending multiple messages in a rebus transaction, it takes a lot of time to confirm each message individually. Since we are reusing the same IModel from the current transaction, it should be safe to confirm all messages in one go. The performance difference when running inside a rebus transaction is huge.

Batch confirms is also recommended from the RabbitMQ webside due to performance and latency.

I extended the current performance tests to also run in transaction to be able to compare side by side.

@kyrrem
Copy link
Author

kyrrem commented Jan 29, 2019

Wanted to connect this issue with the following PR rebus-org/Rebus.RabbitMq#40

But didnt find a way to do that, a bit new to github.

@kyrrem
Copy link
Author

kyrrem commented Jan 29, 2019

This should be in Rebus.RabbitMQ, not Rebus main. Closing.

@kyrrem kyrrem closed this as completed Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant