-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Dockerfile allows conditional full requirements #285
Comments
Thank you! |
Ok will prepare a PR
Sent via Superhuman iOS ( ***@***.*** )
…On Fri, Mar 22 2024 at 13:23, isamu arimoto < ***@***.*** > wrote:
Thank you!
I would like to merge the docker additions and readme changes.
—
Reply to this email directly, view it on GitHub (
#285 (comment) )
, or unsubscribe (
https://github.com/notifications/unsubscribe-auth/AANTCR7ULMD6E3ONMECTF2LYZSHL3AVCNFSM6AAAAABFDU6OSGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJVHA2DSNJQGQ
).
You are receiving this because you authored the thread. Message ID: <snakajima/SlashGPT/issues/285/2015849504
@ github. com>
|
:-$
Sent via Superhuman iOS ( ***@***.*** )
…On Sat, Mar 23 2024 at 01:16, Rich Tong < ***@***.*** > wrote:
Ok will prepare a PR
Sent via Superhuman iOS ( ***@***.*** )
On Fri, Mar 22 2024 at 13:23, isamu arimoto < ***@***.*** >
wrote:
>
>
>
>
>
>
> Thank you!
> I would like to merge the docker additions and readme changes.
>
>
>
> —
> Reply to this email directly, view it on GitHub (
> #285 (comment) )
> , or unsubscribe (
> https://github.com/notifications/unsubscribe-auth/AANTCR7ULMD6E3ONMECTF2LYZSHL3AVCNFSM6AAAAABFDU6OSGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJVHA2DSNJQGQ
> ).
> You are receiving this because you authored the thread. Message ID: <snakajima/SlashGPT/issues/285/2015849504
> @ github. com>
>
>
>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Do you want this fix? basically I need to develop with full requirements sometimes so I modified the dockerfile with a conditional build so the right requirements is copied (also you don't need RUN mkdir, WORKDIR does this already. so
docker build --build-arg BUILD=full -t slashgpt .
worksAlso I added something to Makefile as well to make the loop faster so that
make docker
just drops you into the container :-)The text was updated successfully, but these errors were encountered: