Validate nested reconcilers at test-time #583
Assignees
Comments
|
@scothis would you be so kind and assign this to me? I can't self-assign. |
mamachanko
added a commit
to mamachanko/reconcilerio-runtime
that referenced
this issue
Feb 7, 2025
* Nested validation is configured via the context with reconcilers#WithNestedValidation * (Sub)Reconciler tests always do nested validation * Moves the Validator interface from testing into reconcilers * Sequence now implements the Validator interface. Its Validate is not called from its SetupWithManager to avoid duplicate validations. fixes reconcilerio#583 Signed-off-by: Max Brauer <[email protected]>
mamachanko
added a commit
to mamachanko/reconcilerio-runtime
that referenced
this issue
Feb 7, 2025
* Nested validation is configured via the context with reconcilers#WithNestedValidation * (Sub)Reconciler tests always do nested validation * Moves the Validator interface from testing into reconcilers * Sequence now implements the Validator interface. Its Validate is not called from its SetupWithManager to avoid duplicate validations. fixes reconcilerio#583 Signed-off-by: Max Brauer <[email protected]>
mamachanko
added a commit
to mamachanko/reconcilerio-runtime
that referenced
this issue
Feb 10, 2025
* Nested validation is configured via the context with reconcilers#WithNestedValidation * (Sub)Reconciler tests always do nested validation * Moves the Validator interface from testing into reconcilers * Sequence now implements the Validator interface. Its Validate is not called from its SetupWithManager to avoid duplicate validations. fixes reconcilerio#583 Signed-off-by: Max Brauer <[email protected]>
scothis
pushed a commit
that referenced
this issue
Feb 10, 2025
* Validate nested reconcilers * Nested validation is configured via the context with reconcilers#WithNestedValidation * (Sub)Reconciler tests always do nested validation * Moves the Validator interface from testing into reconcilers * Sequence now implements the Validator interface. Its Validate is not called from its SetupWithManager to avoid duplicate validations. fixes #583 Signed-off-by: Max Brauer <[email protected]> * Move validation into its own package and improve function names Signed-off-by: Max Brauer <[email protected]> * Format validation errors with the error verb to preserve types Signed-off-by: Max Brauer <[email protected]> * Initialize reconcilers when validating for better error messages * A few reconcilers have not had an init method yet. Now, they do. * Aggregate and Advice are defaulting fields on init. That means some their invalid cases are no longer possible. Signed-off-by: Max Brauer <[email protected]> * Validate IfThen#Else Signed-off-by: Max Brauer <[email protected]> --------- Signed-off-by: Max Brauer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is a follow-up for #578.
Given I have a nested reconciler (say
Advice[Sequence[ChildReconciler, ChildReconciler]])When I run tests for the outer reconciler (say
Advice)Then I would like my tests to error (not panic) and to see error messages for any of the reconcilers in the tree (say
ChildReconciler)The text was updated successfully, but these errors were encountered: