From fcbd2748b28d0510564b852106d76fefec161326 Mon Sep 17 00:00:00 2001 From: ObsidianSnoo <66971815+ObsidianSnoo@users.noreply.github.com> Date: Wed, 24 Jul 2024 18:57:49 -0700 Subject: [PATCH] Fix editor overflow: replace deprecated clip with hidden (#28) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## ๐Ÿ’ธ TL;DR - The code editor was pushing the height of the UI beyond the view height - `overflow: clip` requires additional parameters to define the clip margin and has other implications for scrolling - See: https://developer.mozilla.org/en-US/docs/Web/CSS/overflow#clip ## ๐Ÿ“œ Details [Design Doc]() [Jira]() ## ๐Ÿงช Testing Steps / Validation ## โœ… Checks - [ ] CI tests (if present) are passing - [ ] Adheres to code style for repo - [ ] Contributor License Agreement (CLA) completed if not a Reddit employee --- src/elements/play-pen/play-pen.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/elements/play-pen/play-pen.ts b/src/elements/play-pen/play-pen.ts index 577b727..88d6f48 100644 --- a/src/elements/play-pen/play-pen.ts +++ b/src/elements/play-pen/play-pen.ts @@ -108,7 +108,7 @@ export class PlayPen extends LitElement { column-gap: 16px; display: flex; flex-direction: row; - overflow: clip; + overflow: hidden; padding-right: 16px; padding-left: 16px; row-gap: 16px;