From ee5d46751ed054710470678ac6bebb54aa2a2828 Mon Sep 17 00:00:00 2001 From: Taishi Kasuga Date: Sat, 28 Dec 2024 13:23:35 +0900 Subject: [PATCH 1/2] ci: add ruby 3.4 to the matrix --- .github/workflows/test.yaml | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 4a3b2d6..61ef2af 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -27,11 +27,11 @@ jobs: max-parallel: 10 matrix: include: - - {redis: '7.2', ruby: '3.3'} - - {redis: '7.2', ruby: '3.3', compose: compose.ssl.yaml} - - {redis: '7.2', ruby: '3.3', driver: 'hiredis'} - - {redis: '7.2', ruby: '3.3', driver: 'hiredis', compose: compose.ssl.yaml} - - {redis: '7.2', ruby: '3.3', compose: compose.replica.yaml, replica: '2'} + - {redis: '7.2', ruby: '3.4'} + - {redis: '7.2', ruby: '3.4', compose: compose.ssl.yaml} + - {redis: '7.2', ruby: '3.4', driver: 'hiredis'} + - {redis: '7.2', ruby: '3.4', driver: 'hiredis', compose: compose.ssl.yaml} + - {redis: '7.2', ruby: '3.4', compose: compose.replica.yaml, replica: '2'} - {task: test_cluster_down} - {task: test_cluster_broken, restart: 'no', startup: '6'} - {redis: '8', ruby: '3.3', compose: compose.valkey.yaml, replica: '2'} @@ -64,7 +64,7 @@ jobs: - name: Set up Ruby uses: ruby/setup-ruby@v1 with: - ruby-version: ${{ matrix.ruby || '3.3' }} + ruby-version: ${{ matrix.ruby || '3.4' }} bundler-cache: true - name: Pull Docker images run: docker compose --progress quiet -f $DOCKER_COMPOSE_FILE pull @@ -91,7 +91,7 @@ jobs: - name: Set up Ruby uses: ruby/setup-ruby@v1 with: - ruby-version: '3.3' + ruby-version: '3.4' bundler-cache: true - name: Get IP address of host run: | @@ -146,7 +146,7 @@ jobs: - name: Set up Ruby uses: ruby/setup-ruby@v1 with: - ruby-version: '3.3' + ruby-version: '3.4' bundler-cache: true - name: Run rubocop run: bundle exec rubocop @@ -166,7 +166,7 @@ jobs: - name: Set up Ruby uses: ruby/setup-ruby@v1 with: - ruby-version: '3.3' + ruby-version: '3.4' bundler-cache: true - name: Pull Docker images run: docker compose --progress quiet -f $DOCKER_COMPOSE_FILE pull @@ -226,7 +226,7 @@ jobs: - name: Set up Ruby uses: ruby/setup-ruby@v1 with: - ruby-version: '3.3' + ruby-version: '3.4' bundler-cache: true - name: Pull Docker images run: docker compose --progress quiet -f $DOCKER_COMPOSE_FILE pull @@ -264,7 +264,7 @@ jobs: - name: Set up Ruby uses: ruby/setup-ruby@v1 with: - ruby-version: '3.3' + ruby-version: '3.4' bundler-cache: true - name: Pull Docker images run: docker compose --progress quiet -f $DOCKER_COMPOSE_FILE pull @@ -296,7 +296,7 @@ jobs: - name: Set up Ruby uses: ruby/setup-ruby@v1 with: - ruby-version: '3.3' + ruby-version: '3.4' bundler-cache: true - name: Print user limits run: ulimit -a From 8f248729bf195a2010995c26e875ca4c93240c4d Mon Sep 17 00:00:00 2001 From: Taishi Kasuga Date: Sat, 28 Dec 2024 13:32:42 +0900 Subject: [PATCH 2/2] fix --- test/redis_client/test_cluster_config.rb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/redis_client/test_cluster_config.rb b/test/redis_client/test_cluster_config.rb index a4edc48..2d05759 100644 --- a/test/redis_client/test_cluster_config.rb +++ b/test/redis_client/test_cluster_config.rb @@ -6,7 +6,8 @@ class RedisClient class TestClusterConfig < TestingWrapper def test_inspect - want = '#"127.0.0.1", :port=>6379}]>' + cfg = { host: '127.0.0.1', port: 6379 } + want = "#" got = ::RedisClient::ClusterConfig.new.inspect assert_equal(want, got) end