-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CTD Searching RS grid while having items rapidly enter and exit the system #480
Comments
I managed to reproduce it with a minimal setup I had to launch a calculation heavy stuff at the same time to slow down my CPU, but I think that having hundreds of item types make that unecessary steps :
* different than op who had 0.15.6 Crash report
|
Thank you all, this is great! |
From the linked issue a CME occurred at GridViewImpl#sort. It appeared like the backing list was being modified while a sort was happening. I noticed that the GridUpdatePacket runs on a different thread (had execute missing), so this change makes it so that GridUpdatePacket handling should happen on the same thread as the sort, and should avoid the CME happening in the first place. I wasn't able to test this due to the nature of the bug. See #480
This should be fixed for upcoming release v2.0.0-milestone.3.4 for Minecraft 1.20.4. I couldn't test myself so I'm not 100% sure, if the bug persists anyway please let us know. |
Describe the bug
Environment: Fabric 1.20.1, RS2 Milestone 3.2, Extended Drawers 2.1.1
Entering a search query in the RS2 grid while a connected Extended Drawers setup (connected with an external storage interface + access point) that is constantly pulling and pushing single items into connected drawers (important that it's going from an empty to 1-64 stack state then back to 0 repeatedly) will cause the client to CTD or infrequently timeout from server.
How can we reproduce this bug or crash?
Setup simple RS2 system
Connect it to extended drawers using an external storage interface + access point
Continuously input and remove a single item from a connected drawer/ multiple drawers
Search for something inside the grid or generally interact with it
CTD / Server timeout (Netty)
Crash.mov
What Minecraft version is this happening on?
Minecraft 1.20.1
What Forge or Fabric version is this happening on?
0.15.6 Fabric Loader, Fabric API 0.92.0
What Refined Storage version is this happening on?
Milestone 3.2
Relevant log output
The text was updated successfully, but these errors were encountered: