Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with "filament" mod - the item is not properly rendered. #717

Closed
spinodal23 opened this issue Nov 9, 2024 · 6 comments
Closed
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@spinodal23
Copy link

spinodal23 commented Nov 9, 2024

Describe the bug

The items from Toms Server Additions: Stone!(tsa) mod (which uses filament mod) is not shown properly when viewing through the Refined Storage 2 mod.

The "filament" mod helps to add custom items and blocks(by using vanilla items and block) to the game without making a mod.
The reason why "tsa:polished_dripstone_block" is rendered as "minecraft:paper" is because this item uses "minecraft:paper" as a base model.

2024-11-09_20 54 01

2024-11-09_20 54 08

2024-11-09_20 54 34

How can we reproduce this bug or crash?

"tsa:polished_dripstone_block" is in a chest and this chest is connected to the RS system by external storage.
If a chest is used and this item is put in the chest, then I cannot pick this item out using the grid, but putting the item into the chest using the grid works properly.
If a disk is used and this item is put into the disk, then the item can never be picked up.

What Minecraft version is this happening on?

Minecraft 1.21.1

What NeoForge or Fabric version is this happening on?

Fabric api 0.102.1, Fabric loader 0.16.5

What Refined Storage version is this happening on?

refinedstorage-fabric-2.0.0-milestone.4.7

Relevant log output

[20:52:23] [main/INFO]: Loading Minecraft 1.21.1 with Fabric Loader 0.16.5
[20:52:23] [main/INFO]: Loading 80 mods:
	- cloth-config 15.0.130
	   \-- cloth-basic-math 0.6.1
	- fabric-api 0.102.1+1.21.1
	   |-- fabric-api-base 0.4.42+6573ed8c6a
	   |-- fabric-api-lookup-api-v1 1.6.68+b55973446a
	   |-- fabric-biome-api-v1 13.0.29+5bd9f1bc6a
	   |-- fabric-block-api-v1 1.0.22+0af3f5a76a
	   |-- fabric-block-view-api-v2 1.0.10+6573ed8c6a
	   |-- fabric-blockrenderlayer-v1 1.1.52+0af3f5a76a
	   |-- fabric-client-tags-api-v1 1.1.15+6573ed8c6a
	   |-- fabric-command-api-v1 1.2.49+f71b366f6a
	   |-- fabric-command-api-v2 2.2.28+6ced4dd96a
	   |-- fabric-commands-v0 0.2.66+df3654b36a
	   |-- fabric-content-registries-v0 8.0.16+b55973446a
	   |-- fabric-convention-tags-v1 2.0.20+7f945d5b6a
	   |-- fabric-convention-tags-v2 2.6.0+605f22ad6a
	   |-- fabric-crash-report-info-v1 0.2.29+0af3f5a76a
	   |-- fabric-data-attachment-api-v1 1.1.27+1daea2156a
	   |-- fabric-data-generation-api-v1 20.2.17+16c4ae256a
	   |-- fabric-dimensions-v1 4.0.0+6fc22b996a
	   |-- fabric-entity-events-v1 1.6.12+6fc22b996a
	   |-- fabric-events-interaction-v0 0.7.12+ba9dae066a
	   |-- fabric-game-rule-api-v1 1.0.53+6ced4dd96a
	   |-- fabric-item-api-v1 11.0.0+afdfc9216a
	   |-- fabric-item-group-api-v1 4.1.4+780172706a
	   |-- fabric-key-binding-api-v1 1.0.47+0af3f5a76a
	   |-- fabric-keybindings-v0 0.2.45+df3654b36a
	   |-- fabric-lifecycle-events-v1 2.3.12+6c1df3606a
	   |-- fabric-loot-api-v2 3.0.14+3f89f5a56a
	   |-- fabric-loot-api-v3 1.0.2+3f89f5a56a
	   |-- fabric-message-api-v1 6.0.13+6573ed8c6a
	   |-- fabric-model-loading-api-v1 2.0.0+fe474d6b6a
	   |-- fabric-networking-api-v1 4.2.2+60c3209b6a
	   |-- fabric-object-builder-api-v1 15.2.0+40875a936a
	   |-- fabric-particles-v1 4.0.2+6573ed8c6a
	   |-- fabric-recipe-api-v1 5.0.12+650897126a
	   |-- fabric-registry-sync-v0 5.1.2+60c3209b6a
	   |-- fabric-renderer-api-v1 3.4.0+c705a49c6a
	   |-- fabric-renderer-indigo 1.7.0+c705a49c6a
	   |-- fabric-renderer-registries-v1 3.2.68+df3654b36a
	   |-- fabric-rendering-data-attachment-v1 0.3.48+73761d2e6a
	   |-- fabric-rendering-fluids-v1 3.1.6+1daea2156a
	   |-- fabric-rendering-v0 1.1.71+df3654b36a
	   |-- fabric-rendering-v1 5.0.5+df16efd06a
	   |-- fabric-resource-conditions-api-v1 4.3.0+8dc279b16a
	   |-- fabric-resource-loader-v0 1.3.0+565991296a
	   |-- fabric-screen-api-v1 2.0.25+8b68f1c76a
	   |-- fabric-screen-handler-api-v1 1.3.86+b55973446a
	   |-- fabric-sound-api-v1 1.0.23+6573ed8c6a
	   |-- fabric-transfer-api-v1 5.1.17+1db1cc1f6a
	   \-- fabric-transitive-access-wideners-v1 6.1.0+1daea2156a
	- fabricloader 0.16.5
	   \-- mixinextras 0.4.1
	- filament 0.9.3+1.21
	   |-- bil 1.1.12+1.21
	   |-- fabric-permissions-api-v0 0.3.1
	   \-- placeholder-api 2.4.0+1.21
	- java 21
	- logical_zoom 0.0.26
	- minecraft 1.21.1
	- modmenu 11.0.1
	- polymer-bundled 0.9.17+1.21.1
	   |-- polymer-autohost 0.9.17+1.21.1
	   |-- polymer-blocks 0.9.17+1.21.1
	   |-- polymer-common 0.9.17+1.21.1
	   |    \-- packet_tweaker 0.5.5+1.21
	   |-- polymer-core 0.9.17+1.21.1
	   |    |-- polymer-networking 0.9.17+1.21.1
	   |    |    \-- polymer-common 0.9.17+1.21.1
	   |    |         \-- packet_tweaker 0.5.5+1.21
	   |    \-- polymer-registry-sync-manipulator 0.9.17+1.21.1
	   |-- polymer-resource-pack 0.9.17+1.21.1
	   |    \-- polymer-common 0.9.17+1.21.1
	   |         \-- packet_tweaker 0.5.5+1.21
	   \-- polymer-virtual-entity 0.9.17+1.21.1
	        \-- polymer-common 0.9.17+1.21.1
	             \-- packet_tweaker 0.5.5+1.21
	- refinedstorage 2.0.0-milestone.4.7
	   |-- refinedstorage-core-api 2.0.0-milestone.4.7
	   |-- refinedstorage-grid-api 2.0.0-milestone.4.7
	   |-- refinedstorage-network 2.0.0-milestone.4.7
	   |-- refinedstorage-network-api 2.0.0-milestone.4.7
	   |-- refinedstorage-query-parser 2.0.0-milestone.4.7
	   |-- refinedstorage-resource-api 2.0.0-milestone.4.7
	   |-- refinedstorage-storage-api 2.0.0-milestone.4.7
	   \-- team_reborn_energy 4.1.0
	- tsa-stone 1.1.3+1.21-1.21.1
[20:52:24] [main/INFO]: SpongePowered MIXIN Subsystem Version=0.8.7 Source=file:/C:/Users/rjuve/AppData/Roaming/.minecraft/libraries/net/fabricmc/sponge-mixin/0.15.3+mixin.0.8.7/sponge-mixin-0.15.3+mixin.0.8.7.jar Service=Knot/Fabric Env=CLIENT
[20:52:24] [main/INFO]: Compatibility level set to JAVA_17
[20:52:24] [main/INFO]: Compatibility level set to JAVA_21
[20:52:24] [main/INFO]: Initializing MixinExtras via com.llamalad7.mixinextras.service.MixinExtrasServiceImpl(version=0.4.1).
[20:52:25] [Datafixer Bootstrap/INFO]: 226 Datafixer optimizations took 295 milliseconds
[20:52:25] [main/WARN]: Invalid registry value type detected for PerfOS counters. Should be REG_DWORD. Ignoring: HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Services\PerfOS\Performance\Disable Performance Counters.
[20:52:29] [Render thread/INFO]: Environment: Environment[sessionHost=https://sessionserver.mojang.com, servicesHost=https://api.minecraftservices.com, name=PROD]
[20:52:29] [Render thread/INFO]: Setting user: Spinodal
[20:52:29] [Render thread/ERROR]: No data fixer registered for base_projectile
[20:52:29] [Render thread/INFO]: Available Polymer block model types:
[20:52:29] [Render thread/INFO]: 	FULL_BLOCK = 1149
[20:52:29] [Render thread/INFO]: 	TRANSPARENT_BLOCK = 52
[20:52:29] [Render thread/INFO]: 	TRANSPARENT_BLOCK_WATERLOGGED = 52
[20:52:29] [Render thread/INFO]: 	BIOME_TRANSPARENT_BLOCK = 78
[20:52:29] [Render thread/INFO]: 	BIOME_TRANSPARENT_BLOCK_WATERLOGGED = 65
[20:52:29] [Render thread/INFO]: 	FARMLAND_BLOCK = 5
[20:52:29] [Render thread/INFO]: 	VINES_BLOCK = 100
[20:52:29] [Render thread/INFO]: 	PLANT_BLOCK = 7
[20:52:29] [Render thread/INFO]: 	BIOME_PLANT_BLOCK = 15
[20:52:29] [Render thread/INFO]: 	KELP_BLOCK = 25
[20:52:29] [Render thread/INFO]: 	CACTUS_BLOCK = 15
[20:52:29] [Render thread/INFO]: 	SCULK_SENSOR_BLOCK = 150
[20:52:29] [Render thread/INFO]: 	SCULK_SENSOR_BLOCK_WATERLOGGED = 150
[20:52:29] [Render thread/INFO]: 	TRIPWIRE_BLOCK = 32
[20:52:29] [Render thread/INFO]: 	TRIPWIRE_BLOCK_FLAT = 32
[20:52:29] [Render thread/INFO]: 	TOP_SLAB = 5
[20:52:29] [Render thread/INFO]: 	TOP_SLAB_WATERLOGGED = 5
[20:52:29] [Render thread/INFO]: 	BOTTOM_SLAB = 5
[20:52:29] [Render thread/INFO]: 	BOTTOM_SLAB_WATERLOGGED = 5
[20:52:29] [Render thread/INFO]: 	TOP_TRAPDOOR = 20
[20:52:29] [Render thread/INFO]: 	BOTTOM_TRAPDOOR = 20
[20:52:29] [Render thread/INFO]: 	NORTH_TRAPDOOR = 20
[20:52:29] [Render thread/INFO]: 	EAST_TRAPDOOR = 20
[20:52:29] [Render thread/INFO]: 	SOUTH_TRAPDOOR = 20
[20:52:29] [Render thread/INFO]: 	WEST_TRAPDOOR = 20
[20:52:29] [Render thread/INFO]: 	TOP_TRAPDOOR_WATERLOGGED = 20
[20:52:29] [Render thread/INFO]: 	BOTTOM_TRAPDOOR_WATERLOGGED = 20
[20:52:29] [Render thread/INFO]: 	NORTH_TRAPDOOR_WATERLOGGED = 20
[20:52:29] [Render thread/INFO]: 	EAST_TRAPDOOR_WATERLOGGED = 20
[20:52:29] [Render thread/INFO]: 	SOUTH_TRAPDOOR_WATERLOGGED = 20
[20:52:29] [Render thread/INFO]: 	WEST_TRAPDOOR_WATERLOGGED = 20
[20:52:29] [Render thread/INFO]: 	NORTH_DOOR = 160
[20:52:29] [Render thread/INFO]: 	EAST_DOOR = 160
[20:52:29] [Render thread/INFO]: 	SOUTH_DOOR = 160
[20:52:29] [Render thread/INFO]: 	WEST_DOOR = 160
[20:52:30] [Render thread/INFO]: [Indigo] Registering Indigo renderer!
[20:52:30] [Render thread/INFO]: Checking mod updates...
[20:52:31] [Worker-Main-1/INFO]: Update available for '[email protected]+1.21.1', (-> 0.107.0+1.21.1)
[20:52:31] [Worker-Main-1/INFO]: Update available for '[email protected]', (-> 15.0.140+fabric)
[20:52:31] [Worker-Main-1/INFO]: Update available for '[email protected]', (-> 11.0.3)
[20:52:31] [Worker-Main-1/INFO]: Update available for '[email protected]+1.21.1', (-> 0.9.18+1.21.1)
[20:52:31] [Worker-Main-1/INFO]: Update available for '[email protected]+1.21', (-> 0.9.9+1.21)
[20:52:31] [Render thread/INFO]: Backend library: LWJGL version 3.3.3-snapshot
[20:52:31] [ModMenu/Update Checker/Fabric Loader/INFO]: Update available for '[email protected]'
[20:52:32] [Render thread/WARN]: Missing metadata in pack file/glowing-glazed-1.20~1.20.1에서도 되게 한빛달래 수정.zip
[20:52:32] [Render thread/WARN]: Missing metadata in pack file/ore-highlighter-e3391_1.18.1.zip
[20:52:32] [Render thread/INFO]: Found non-pack entry 'C:\Users\rjuve\AppData\Roaming\.minecraft\resourcepacks\데이터 참고', ignoring
[20:52:32] [Render thread/INFO]: Found non-pack entry 'C:\Users\rjuve\AppData\Roaming\.minecraft\resourcepacks\리소스팩 및 셰이더팩 출처.xlsx', ignoring
[20:52:32] [Render thread/INFO]: Found non-pack entry 'C:\Users\rjuve\AppData\Roaming\.minecraft\resourcepacks\안 쓰는 리소스팩', ignoring
[20:52:32] [Render thread/INFO]: Found non-pack entry 'C:\Users\rjuve\AppData\Roaming\.minecraft\resourcepacks\한빛달래 1.19 서버 추천 리소스팩 및 셰이더팩', ignoring
[20:52:32] [Render thread/WARN]: Removed resource pack continuity:default from options because it doesn't seem to exist anymore
[20:52:32] [Render thread/WARN]: Removed resource pack continuity:glass_pane_culling_fix from options because it doesn't seem to exist anymore
[20:52:32] [Render thread/INFO]: Reloading ResourceManager: vanilla, fabric, bil, cloth-config, fabric-api, fabric-api-base, fabric-api-lookup-api-v1, fabric-biome-api-v1, fabric-block-api-v1, fabric-block-view-api-v2, fabric-blockrenderlayer-v1, fabric-client-tags-api-v1, fabric-command-api-v1, fabric-command-api-v2, fabric-commands-v0, fabric-content-registries-v0, fabric-convention-tags-v1, fabric-convention-tags-v2, fabric-crash-report-info-v1, fabric-data-attachment-api-v1, fabric-data-generation-api-v1, fabric-dimensions-v1, fabric-entity-events-v1, fabric-events-interaction-v0, fabric-game-rule-api-v1, fabric-item-api-v1, fabric-item-group-api-v1, fabric-key-binding-api-v1, fabric-keybindings-v0, fabric-lifecycle-events-v1, fabric-loot-api-v2, fabric-loot-api-v3, fabric-message-api-v1, fabric-model-loading-api-v1, fabric-networking-api-v1, fabric-object-builder-api-v1, fabric-particles-v1, fabric-recipe-api-v1, fabric-registry-sync-v0, fabric-renderer-api-v1, fabric-renderer-indigo, fabric-renderer-registries-v1, fabric-rendering-data-attachment-v1, fabric-rendering-fluids-v1, fabric-rendering-v0, fabric-rendering-v1, fabric-resource-conditions-api-v1, fabric-resource-loader-v0, fabric-screen-api-v1, fabric-screen-handler-api-v1, fabric-sound-api-v1, fabric-transfer-api-v1, fabric-transitive-access-wideners-v1, fabricloader, logical_zoom, modmenu, placeholder-api, polymer-blocks, polymer-core, polymer-resource-pack, refinedstorage, team_reborn_energy, tsa-stone, file/1.21.1_Visible Ores2.12 - 한빛달래 1.21.1 호환되게 수정.zip, file/1.21.1_glowing-glazed-1-21.zip, file/1.21.1_EvenBetterEnchants_v2_r1.zip, file/1.21.1_Arjuna - RS 1.20.1 [v0.9] - 한빛달래 1.21.1 호환되게 수정.zip, $polymer-resources
[20:52:32] [Worker-Main-5/INFO]: Found unifont_jp_patch-15.1.05.hex, loading
[20:52:32] [Worker-Main-10/INFO]: Found unifont_all_no_pua-15.1.05.hex, loading
[20:52:32] [Worker-Main-11/WARN]: Unable to load model: 'minecraft:note_block' referenced from: minecraft:custom/block/dripstone/dripstone_bricks: java.io.FileNotFoundException: minecraft:models/note_block.json
[20:52:34] [Render thread/WARN]: Missing sound for event: minecraft:item.goat_horn.play
[20:52:34] [Render thread/WARN]: Missing sound for event: minecraft:entity.goat.screaming.horn_break
[20:52:34] [Render thread/INFO]: OpenAL initialized on device OpenAL Soft on 스피커(USB PnP Audio Device)
[20:52:34] [Render thread/INFO]: Sound engine started
[20:52:35] [Render thread/INFO]: Created: 16384x8192x4 minecraft:textures/atlas/blocks.png-atlas
[20:52:35] [Render thread/INFO]: Created: 256x256x4 minecraft:textures/atlas/signs.png-atlas
[20:52:35] [Render thread/INFO]: Created: 512x512x4 minecraft:textures/atlas/banner_patterns.png-atlas
[20:52:35] [Render thread/INFO]: Created: 512x512x4 minecraft:textures/atlas/shield_patterns.png-atlas
[20:52:35] [Render thread/INFO]: Created: 1024x1024x4 minecraft:textures/atlas/armor_trims.png-atlas
[20:52:35] [Render thread/INFO]: Created: 256x256x4 minecraft:textures/atlas/chest.png-atlas
[20:52:35] [Render thread/INFO]: Created: 128x64x4 minecraft:textures/atlas/decorated_pot.png-atlas
[20:52:35] [Render thread/INFO]: Created: 512x256x4 minecraft:textures/atlas/shulker_boxes.png-atlas
[20:52:35] [Render thread/INFO]: Created: 512x256x4 minecraft:textures/atlas/beds.png-atlas
[20:52:35] [Render thread/INFO]: Created: 512x256x0 minecraft:textures/atlas/particles.png-atlas
[20:52:35] [Render thread/INFO]: Created: 512x256x0 minecraft:textures/atlas/paintings.png-atlas
[20:52:35] [Render thread/INFO]: Created: 256x128x0 minecraft:textures/atlas/mob_effects.png-atlas
[20:52:35] [Render thread/INFO]: Created: 64x64x0 minecraft:textures/atlas/map_decorations.png-atlas
[20:52:35] [Render thread/INFO]: Created: 1024x1024x0 minecraft:textures/atlas/gui.png-atlas
[20:52:35] [Render thread/WARN]: Shader rendertype_entity_translucent_emissive could not find sampler named Sampler2 in the specified shader program.
[20:52:41] [Render thread/INFO]: Deleting level qwerty
[20:52:41] [Render thread/INFO]: Attempt 1...
[20:52:43] [Render thread/INFO]: Deleting level asdf
[20:52:43] [Render thread/INFO]: Attempt 1...
[20:52:44] [Render thread/INFO]: Found new data pack $polymer-resources, loading it automatically
[20:52:44] [Render thread/INFO]: filament models registered: 0
[20:52:44] [Render thread/INFO]: Filament items registered: 0
[20:52:44] [Render thread/INFO]: Filament blocks registered: 11
[20:52:44] [Render thread/INFO]: Filament decorations registered: 0
[20:52:44] [Render thread/INFO]: Filament decoration block entities registered: 0
[20:52:44] [Render thread/INFO]: filament models registered: 0
[20:52:44] [Render thread/INFO]: Loaded 1672 recipes
[20:52:45] [Render thread/INFO]: Loaded 1705 advancements
[20:52:51] [Render thread/INFO]: filament models registered: 0
[20:52:51] [Render thread/INFO]: filament models registered: 0
[20:52:51] [Render thread/INFO]: Loaded 1673 recipes
[20:52:51] [Render thread/INFO]: Loaded 1706 advancements
[20:52:54] [Render thread/INFO]: Applied 0 biome modifications to 0 of 64 new biomes in 895.6 μs
[20:52:54] [Server thread/INFO]: Starting integrated minecraft server version 1.21.1
[20:52:54] [Server thread/INFO]: Generating keypair
[20:52:55] [Server thread/INFO]: Preparing start region for dimension minecraft:overworld
[20:52:55] [Render thread/INFO]: Preparing spawn area: 2%
[20:52:56] [Render thread/INFO]: Preparing spawn area: 2%
[20:52:56] [Render thread/INFO]: Preparing spawn area: 18%
[20:52:57] [Render thread/INFO]: Preparing spawn area: 51%
[20:52:57] [Render thread/INFO]: Time elapsed: 1853 ms
[20:52:57] [Server thread/INFO]: Changing view distance to 20, from 10
[20:52:57] [Server thread/INFO]: Changing simulation distance to 12, from 0
[20:52:58] [Server thread/INFO]: Spinodal[local:E:647b27e7] logged in with entity id 19 at (87.5, 64.0, -57.5)
[20:52:58] [Server thread/INFO]: Spinodal joined the game
[20:52:58] [Render thread/INFO]: Loaded 2 advancements
[20:52:58] [Server thread/INFO]: Saving and pausing game...
[20:52:58] [Server thread/INFO]: Saving chunks for level 'ServerLevel[asdf]'/minecraft:overworld
[20:52:58] [Server thread/INFO]: Saving chunks for level 'ServerLevel[asdf]'/minecraft:the_nether
[20:52:58] [Server thread/INFO]: Saving chunks for level 'ServerLevel[asdf]'/minecraft:the_end
[20:53:17] [Server thread/INFO]: Spinodal has made the advancement [Storing externally]
[20:53:17] [Render thread/INFO]: [System] [CHAT] Spinodal has made the advancement [Storing externally]
[20:53:17] [Render thread/INFO]: Loaded 20 advancements
[20:53:24] [Server thread/INFO]: Spinodal has made the advancement [Upgrading your Grid]
[20:53:24] [Render thread/INFO]: [System] [CHAT] Spinodal has made the advancement [Upgrading your Grid]
[20:53:24] [Render thread/INFO]: Loaded 40 advancements
[20:53:31] [Render thread/INFO]: Loaded 43 advancements
[20:53:36] [Render thread/INFO]: Loaded 45 advancements
[20:54:01] [Render thread/INFO]: [System] [CHAT] Saved screenshot as 2024-11-09_20.54.01.png
[20:54:04] [Render thread/INFO]: Sorting grid view
[20:54:04] [Render thread/INFO]: Initializing grid screen
[20:54:08] [Render thread/INFO]: [System] [CHAT] Saved screenshot as 2024-11-09_20.54.08.png
[20:54:34] [Render thread/INFO]: [System] [CHAT] Saved screenshot as 2024-11-09_20.54.34.png
[20:54:35] [Server thread/INFO]: Saving and pausing game...
[20:54:35] [Server thread/INFO]: Saving chunks for level 'ServerLevel[asdf]'/minecraft:overworld
[20:54:35] [Server thread/INFO]: Saving chunks for level 'ServerLevel[asdf]'/minecraft:the_nether
[20:54:35] [Server thread/INFO]: Saving chunks for level 'ServerLevel[asdf]'/minecraft:the_end
[20:54:35] [Server thread/INFO]: Spinodal lost connection: Disconnected
[20:54:35] [Server thread/INFO]: Spinodal left the game
[20:54:35] [Server thread/INFO]: Stopping singleplayer server as player logged out
[20:54:36] [Server thread/INFO]: Stopping server
[20:54:36] [Server thread/INFO]: Saving players
[20:54:36] [Server thread/INFO]: Saving worlds
[20:54:36] [Server thread/INFO]: Saving chunks for level 'ServerLevel[asdf]'/minecraft:overworld
[20:54:37] [Server thread/INFO]: Saving chunks for level 'ServerLevel[asdf]'/minecraft:the_nether
[20:54:37] [Server thread/INFO]: Saving chunks for level 'ServerLevel[asdf]'/minecraft:the_end
[20:54:37] [Server thread/INFO]: ThreadedAnvilChunkStorage (asdf): All chunks are saved
[20:54:37] [Server thread/INFO]: ThreadedAnvilChunkStorage (DIM-1): All chunks are saved
[20:54:37] [Server thread/INFO]: ThreadedAnvilChunkStorage (DIM1): All chunks are saved
[20:54:37] [Server thread/INFO]: ThreadedAnvilChunkStorage: All dimensions are saved
[20:54:39] [Render thread/INFO]: Stopping!
@spinodal23 spinodal23 added the bug Something isn't working label Nov 9, 2024
@raoulvdberge
Copy link
Contributor

Hello, have you reported this to the filament mod? Refined Storage renders items the standard way.

@Patbox
Copy link

Patbox commented Dec 7, 2024

Technically it's an incompatibility with Polymer rather than Filament (it uses polymer for item implementation).

Polymer is a library allowing you to register modded items/blocks/etc, that are compatible with vanilla clients (but have full modded flexibility server side). It works by replacing the polymer-marked modded item (in this case tsa:polished_dripstone_block) into vanilla-friendly representation (a minecraft:paper with additional set of companent). This conversion happens within ItemStack's network codec, as it requires all information for correct conversion.
I imagine Refined Storage writes/serializes these two on it's own seperately (so it writes the Item entry first, then component changes) without using ItemStack network codecs. This makes it run through "generic" conversion, that can't modify components depending on item (and item depending on component).

On way to solve it is to use vanilla ItemStack network codec for sending that data (can be either full one with count or countless one), which might also be compatible with your current networking implementation depending on packet format

@raoulvdberge
Copy link
Contributor

Ah, thank you for clarifying. Indeed, Refined Storage uses its own codecs for resource syncing. I'll see what I can do about this.

@raoulvdberge
Copy link
Contributor

raoulvdberge commented Dec 7, 2024

@Patbox This is a bit tricky. RS uses its own ItemResource instead of ItemStack. I don't think it's a good idea to convert every ItemResource to an ItemStack for every network sync, so I think the mods are incompatible.

@Patbox
Copy link

Patbox commented Dec 7, 2024

You could probably store ItemStack internally and provide utility methods for item/component access in ItemResource, so no conversion would be needed, but this is your call here. Other idea that would work would be doing the conversion when payload packet is sent, aka with an xmap of ItemStack network codec. I don't think it would effect performance in any noticable way (polymer does more logic there already and it never became an performance issue)

@raoulvdberge
Copy link
Contributor

I don't think it's acceptable to be doing ItemStack conversions on the fly or even storing a cached ItemStack on every ItemResource, if that's what you're suggesting.

I'll close this issue for now, but thanks for thinking along :-)

@github-project-automation github-project-automation bot moved this from Todo to Done in Refined Storage 2 Dec 7, 2024
@raoulvdberge raoulvdberge added the wontfix This will not be worked on label Dec 7, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants