-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incompatibility with "filament" mod - the item is not properly rendered. #717
Comments
Hello, have you reported this to the filament mod? Refined Storage renders items the standard way. |
Technically it's an incompatibility with Polymer rather than Filament (it uses polymer for item implementation). Polymer is a library allowing you to register modded items/blocks/etc, that are compatible with vanilla clients (but have full modded flexibility server side). It works by replacing the polymer-marked modded item (in this case On way to solve it is to use vanilla ItemStack network codec for sending that data (can be either full one with count or countless one), which might also be compatible with your current networking implementation depending on packet format |
Ah, thank you for clarifying. Indeed, Refined Storage uses its own codecs for resource syncing. I'll see what I can do about this. |
@Patbox This is a bit tricky. RS uses its own |
You could probably store ItemStack internally and provide utility methods for item/component access in ItemResource, so no conversion would be needed, but this is your call here. Other idea that would work would be doing the conversion when payload packet is sent, aka with an xmap of ItemStack network codec. I don't think it would effect performance in any noticable way (polymer does more logic there already and it never became an performance issue) |
I don't think it's acceptable to be doing ItemStack conversions on the fly or even storing a cached ItemStack on every ItemResource, if that's what you're suggesting. I'll close this issue for now, but thanks for thinking along :-) |
Describe the bug
The items from Toms Server Additions: Stone!(tsa) mod (which uses filament mod) is not shown properly when viewing through the Refined Storage 2 mod.
The "filament" mod helps to add custom items and blocks(by using vanilla items and block) to the game without making a mod.
The reason why "tsa:polished_dripstone_block" is rendered as "minecraft:paper" is because this item uses "minecraft:paper" as a base model.
How can we reproduce this bug or crash?
"tsa:polished_dripstone_block" is in a chest and this chest is connected to the RS system by external storage.
If a chest is used and this item is put in the chest, then I cannot pick this item out using the grid, but putting the item into the chest using the grid works properly.
If a disk is used and this item is put into the disk, then the item can never be picked up.
What Minecraft version is this happening on?
Minecraft 1.21.1
What NeoForge or Fabric version is this happening on?
Fabric api 0.102.1, Fabric loader 0.16.5
What Refined Storage version is this happening on?
refinedstorage-fabric-2.0.0-milestone.4.7
Relevant log output
The text was updated successfully, but these errors were encountered: