Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sage installation failed #38

Open
videlec opened this issue Nov 6, 2017 · 9 comments
Open

Sage installation failed #38

videlec opened this issue Nov 6, 2017 · 9 comments

Comments

@videlec
Copy link

videlec commented Nov 6, 2017

Following the instructions at http://sageregina.unhyperbolic.org/ I failed to install Regina. My Sage is in version 8.1.beta9 on a recent archlinux (gcc 7.2.0). The command used is

$ sage -pip install sageRegina

The log is regina.log.gz.

@WPettersson
Copy link
Member

@unhyperbolic I'm guessing this is something you can look into?

@baburton
Copy link
Member

baburton commented Nov 17, 2017 via email

@videlec
Copy link
Author

videlec commented Nov 17, 2017

Do you have instructions somewhere to build from sources?

@unhyperbolic
Copy link
Contributor

unhyperbolic commented Nov 17, 2017

The relevant errors are below. It appears that that a #include functional is missing. Can that be? My only other explanation is that with the new version of sage, sageRegina's install script is no longer passing some compiler flags to gcc.

videlec: You can download sageRegina at https://pypi.python.org/pypi/sageRegina/5.1-1, unpack it and call "sage -python setup.py build" and "sage -python setup.py install" to build from src.

regina_4c65424/engine/triangulation/dim3/triangulation3.h: Au niveau global:
regina_4c65424/engine/triangulation/dim3/triangulation3.h:2819:24: error: « function » dans l'espace de noms « std » ne nomme pas un type de patron
             const std::function<bool(Triangulation<3>&)>& action) const;
                        ^~~~~~~~
regina_4c65424/engine/triangulation/dim3/triangulation3.h:2819:32: error: expected « , » or « ... » before « < » token
             const std::function<bool(Triangulation<3>&)>& action) const;
                                ^
In file included from regina_4c65424/engine/triangulation/dim3.h:45:0,
                 from regina_4c65424/engine/triangulation/xmltrireader3.cpp:34:
regina_4c65424/engine/triangulation/dim3/triangulation3.h: Dans la fonction membre « bool regina::Triangulation<3>::retriangulate(int, unsigned int, regina::ProgressTrackerOpen*, Action&&, Args&& ...) const »:
regina_4c65424/engine/triangulation/dim3/triangulation3.h:2989:14: error: « bind » n'est pas un membre de « std »
         std::bind(action, std::placeholders::_1, args...));
              ^~~~
regina_4c65424/engine/triangulation/dim3/triangulation3.h:2989:14: note: alternatives suggérées: « find »
         std::bind(action, std::placeholders::_1, args...));
              ^~~~
              find
regina_4c65424/engine/triangulation/dim3/triangulation3.h:2989:32: error: « std::placeholders » n'a pas été déclaré
         std::bind(action, std::placeholders::_1, args...));

@WPettersson
Copy link
Member

Yup, that's the GCC7 issue. If you add

#include <functional>

to engine/triangulation/dim3/triangulation3.h that should fix it. Commit 9bab3c9 is the fix in master.

@unhyperbolic
Copy link
Contributor

videlec:
I just created a new sageRegina package that should include the fix. You can try it out like this:

sage -pip install http://sageRegina.unhyperbolic.org/sageRegina-5.1_2d18496.tar.gz --log reginaInstall.log

@videlec
Copy link
Author

videlec commented Nov 19, 2017

Successfully installed sageRegina-5.1-2d18496. Thanks.

@unhyperbolic
Copy link
Contributor

Sage 8.1 is officially out, so sageRegina won't compile with the latest official Sage anymore. When will the next regina release be?

If it is really soon, I will just wait to do the next sageRegina release when regina is released.
It it is soon, I will release the file from the previous comment as pre-release sageRegina-5.2a0.
It it will take a while, I will patch regina 5.1 to just include the missing header and release as sageRegina-5.1-2.

@baburton
Copy link
Member

baburton commented Dec 14, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants