From e1b2fe8f14411a5ff6273f4ec7b5ccffe5d99766 Mon Sep 17 00:00:00 2001
From: David Sinclair <24573542+sikhote@users.noreply.github.com>
Date: Fri, 17 Jan 2025 09:49:24 -0800
Subject: [PATCH] modal-patch-mobile (#199)
Remove container on body to fix older Chrome versions
---
src/components/modal/examples/Modal.vue | 5 +++++
src/components/modal/styles/CdrModal.module.scss | 2 +-
src/dev/SinkWrapper.vue | 1 +
src/styles/cdr-reset.scss | 2 --
4 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/src/components/modal/examples/Modal.vue b/src/components/modal/examples/Modal.vue
index 2dee9d59e..d8a970af7 100644
--- a/src/components/modal/examples/Modal.vue
+++ b/src/components/modal/examples/Modal.vue
@@ -75,6 +75,7 @@
+
@@ -113,4 +114,8 @@ export default {
min-height: 80vh; /* fixes a safari display bug */
}
}
+
+.spacer {
+ height: 100vh;
+}
diff --git a/src/components/modal/styles/CdrModal.module.scss b/src/components/modal/styles/CdrModal.module.scss
index 563550beb..e09f584f5 100644
--- a/src/components/modal/styles/CdrModal.module.scss
+++ b/src/components/modal/styles/CdrModal.module.scss
@@ -10,7 +10,7 @@ $modal-animation-duration: 150ms;
}
inset: 0;
- height: 100vh;
+ height: 100%;
overflow-y: scroll;
position: fixed;
visibility: visible;
diff --git a/src/dev/SinkWrapper.vue b/src/dev/SinkWrapper.vue
index b7f65dfa3..5f96d2447 100644
--- a/src/dev/SinkWrapper.vue
+++ b/src/dev/SinkWrapper.vue
@@ -67,6 +67,7 @@ export default {
align-items: center;
gap: 8px;
margin-bottom: 8px;
+ container-type: inline-size;
}
&__container {
diff --git a/src/styles/cdr-reset.scss b/src/styles/cdr-reset.scss
index 3f47c0ae9..2c2c79f50 100644
--- a/src/styles/cdr-reset.scss
+++ b/src/styles/cdr-reset.scss
@@ -45,8 +45,6 @@ body {
/* cdr-color-background-primary */
background-color: #ffffff;
- container-name: cdr-body;
- container-type: inline-size;
}
h1,