Rust crates with regexmanager don't get updated

[davidkna]

Sample repository: https://github.com/davidkna/renovate-cargo-install

The following renovate config doesn't seem to update the binary crates that get installed in the workflow file (run: cargo install --version 0.4.7 cargo-llvm-cov), despite successfully picking up the current version:

{
    "$schema": "https://docs.renovatebot.com/renovate-schema.json",
    "extends": ["config:base"],
    "regexManagers": [{
      "fileMatch": ["^(workflow-templates|\\.github\\/workflows)\\/[^/]+\\.ya?ml$"],
      "matchStrings": ["cargo install.*--version (?<currentValue>\\S+).*\\s(?<depName>\\S+)"],
      "datasourceTemplate": "crate"
    }]
 }

Partial log output:

DEBUG: packageFiles with updates
{
  "baseBranch": "main",
  "config": {
    "regex": [
      {
        "packageFile": ".github/workflows/workflow.yml",
        "deps": [
          {
            "depName": "cargo-llvm-cov",
            "currentValue": "0.4.7",
            "datasource": "crate",
            "replaceString": "cargo install --version 0.4.7 cargo-llvm-cov",
            "depIndex": 0,
            "updates": [],
            "warnings": [],
            "versioning": "cargo",
            "sourceUrl": "https://github.com/taiki-e/cargo-llvm-cov",
            "dependencyUrl": "https://crates.io/crates/cargo-llvm-cov",
            "currentVersion": "0.4.7"
          }
        ],
        "matchStrings": [
          "cargo install.*--version (?<currentValue>\\S+).*\\s(?<depName>\\S+)"
        ],
        "datasourceTemplate": "crate"
      }
    ]
  }
}

Is this a bug in renovate, or is there something wrong with my config?

[Gabriel-Ladzaretti]

I've debugged this, and it seems that all valid release updates are being filtered out as there is no lockedVersion as you are using a regexManger and obviously there is not lock file present.

renovate/lib/workers/repository/process/lookup/index.ts

Lines 266 to 268 in dafda2e

	for (const [bucket, releases] of Object.entries(buckets)) {
	const sortedReleases = releases.sort((r1, r2) =>
	versioning.sortVersions(r1.version, r2.version)

...

renovate/lib/workers/repository/process/lookup/index.ts

Lines 300 to 303 in dafda2e

	if (!update.newValue || update.newValue === currentValue) {
	if (!lockedVersion) {
	continue;
	}

@viceice WDYT?

[viceice]

it's probably the versioning. major is zero, so renovate won't update to next minor. locked version isn't required for PR.

[Gabriel-Ladzaretti]

problem is that the update array is empty as all valid releases are being filtered out

edit:
there is only non-major bucket -

[viceice]

as i said, it's a versioning issue. checkout cargo versioning. by default separate minor and patch is disabled, so that's why there is only a non major bucket.

cargo uses semver 2.0, so our renovate cargo extend npm versioning.

when major is zero, minor is change is like a unstable update, which is suppressed by ignore unstable setting.

[Gabriel-Ladzaretti]

You are probably right, seems disabling ignoreUnstable doesn't help here either

DEBUG: Checking for config file in C:\projects\ladzaretti-renovate/config.js
 WARN: Config needs migrating
       "originalConfig": {
         ....
         "ignoreUnstable": false,

...
"config": {
         "regex": [
           {
             "packageFile": ".github/workflows/workflow.yml",
             "deps": [
               {
                 ...
                 "updates": [],
                 "warnings": [],
                 "versioning": "cargo",
                 "sourceUrl": "https://github.com/taiki-e/cargo-llvm-cov",
                 "dependencyUrl": "https://crates.io/crates/cargo-llvm-cov",
                 "currentVersion": "0.4.7"
               }
             ],

[williamboman]

I got somewhat stuck at this as well. I use a custom regexManager to update crates (not expressed in a Cargo.toml file but in a custom file format). Reading the README of the cargo versioning strategy helped me realize it rightfully treats versions according to the cargo spec:

In Cargo, 1.2.3 doesn't mean "exactly 1.2.3", it actually means >=1.2.3 <2.0.0. So this is like the equivalent of ^1.2.3 in npm.

Changing versioning to semver for the regex manager made it behave as I'd expect (treats versions as fixed):

{
  regexManagers: [
    {
      fileMatch: "package\\.yaml$",
      matchStrings: [
        "pkg:cargo\\/(?<depName>.+)@(?<currentValue>.+)"
      ],
      datasourceTemplate: "crate",
      // In cargo versioning, "1.2.3" doesn't mean "exactly 1.2.3" but rather ">=1.2.3 <2.0.0".
      // We on the other hand do want to treat versions as fixed - so we change versioning strategy.
      versioningTemplate: "semver",
    },
  ]
}

[gillyobeast]

one can also use versioning in a packageRules section to achieve the same thing, if you're using the regex manager to update from multiple datasources and don't want to override the versioning for other datasources:

{
      // When upgrading tool versions from cargo in .env with regex, use semver instead of cargo's versioning.
      matchManagers: [
        "regex"
      ],
      matchDatasources: [
        "crate"
      ],
      versioning: "semver"
    }