Unsupported range strategy when using custom manager with ruby versioning #28090
Replies: 3 comments 12 replies
-
|
What is the request here - to support rangeStrategy=pin for custom managers? |
Beta Was this translation helpful? Give feedback.
-
|
Sorry, it's too much of a niche issue for me to be able to spend further time on myself |
Beta Was this translation helpful? Give feedback.
-
|
Does that mean you will also not accept pull requests? |
Beta Was this translation helpful? Give feedback.
-
|
Not all all, we'd be happy to accept any elegant/maintainable solution to the problem and you're also welcome to ask for feedback on implementation ideas prior to writing code if you narrow the problem any further |
Beta Was this translation helpful? Give feedback.
-
|
It seems to help loading the manager like in the other methods there, looking for --- lib/modules/manager/index.ts
+++ lib/modules/manager/index.ts
@@ -78,10 +78,13 @@ export function extractPackageFile(
export function getRangeStrategy(config: RangeConfig): RangeStrategy | null {
const { manager, rangeStrategy } = config;
- if (!manager || !managers.has(manager)) {
+ if (!manager) {
+ return null;
+ }
+ const m = managers.get(manager)! ?? customManagers.get(manager)!;
+ if (!m) {
return null;
}
- const m = managers.get(manager)!;
if (m.getRangeStrategy) {
// Use manager's own function if it exists
const managerRangeStrategy = m.getRangeStrategy(config);I've only run it on my repositories, where it did detect updates now and created correct PRs. |
Beta Was this translation helpful? Give feedback.
-
|
Ah much appreciated! Made #33800. |
Beta Was this translation helpful? Give feedback.
-
|
Hi there, Please do not unnecessarily For example, never It's OK to comment in an issue or discussion after multiple days or weeks. But please, still don't Thanks, the Renovate team |
Beta Was this translation helpful? Give feedback.
-
|
Resolved by #33800 |
Beta Was this translation helpful? Give feedback.
-
|
Reverted by #34083 because of: |
Beta Was this translation helpful? Give feedback.
-
What would you like help with?
I think I found a bug
How are you running Renovate?
Mend Renovate hosted app on github.com
If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.
37.265.0
Please tell us more about your question or problem
We were using
regexManagersas a workaround to support version updates in.gemspecfiles. After upgrading tocustomManagerswe now see the following warning in the dependency dashboard:The renovate config in question:
{ "includeForks": true, "automerge": false, "branchConcurrentLimit": 2, "branchPrefix": "renovate-", "bumpVersion": "patch", "dependencyDashboard": true, "extends": ["config:base"], "rangeStrategy": "pin", "customManagers": [ { "customType" : "regex", "fileMatch": [ "^.*\\.gemspec" ], "matchStrings": [ ".*\\.add_(:?(?<depType>.*?)_)?dependency\\s*(['\"])(?<depName>[^'\"]+)(['\"])(\\s*,\\s*(?<currentValue>(['\"])[^'\"]+['\"](\\s*,\\s*['\"][^'\"]+['\"])?))?" ], "datasourceTemplate": "rubygems", "versioningTemplate": "ruby" } ] }An an example repository can be found in mpkorstanje/renovate-gemspec-minimal-example. Ideally I would be able to set the
rangeStrategyon the custom manager, or lacking one, fall back to the gobaly configured range strategy.Note: This issue is spun out from #10616.
Debugging notes
While debugging 37.265.0 against the example it appears that this code here:
renovate/lib/modules/manager/index.ts
Lines 79 to 83 in 3bfad40
Is checking against the
managerListwhich do not include thecustomManagersrather than theallManagersList:renovate/lib/modules/manager/index.ts
Lines 16 to 19 in 3bfad40
And then
nullreturned bygetRangeStrategyeventually ends up ingetNewValuerenovate/lib/modules/versioning/ruby/index.ts
Lines 143 to 144 in 3bfad40
Now technically what the correct resolution would be I'm not sure. The
customManagersappear to be a list of strings rather than actual manager objects.Logs (if relevant)
Logs
Beta Was this translation helpful? Give feedback.
All reactions