From 31bc8cd8d28b2bb20fb885458f0bac375c75f40c Mon Sep 17 00:00:00 2001 From: Ilya Hancharyk Date: Mon, 20 Nov 2023 21:43:54 +0300 Subject: [PATCH] Remove logLaunchLink option. Update changelog --- CHANGELOG.md | 3 +-- README.md | 1 - __tests__/mocks/reportportal-client.mock.js | 1 - index.js | 6 ------ utils/objectUtils.js | 1 - 5 files changed, 1 insertion(+), 11 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 59709f8..03d9d0e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,10 +1,9 @@ -### Added -- Logging link to the launch on its finish. ### Fixed - `isLaunchMergeRequired` option from `client-javascript` missed. ### Changed - `@reportportal/client-javascript` bumped to version `5.0.15`. `launchUuidPrint` and `launchUuidPrintOutput` configuration options introduced. - Readme file updated. +- Logging link to the launch on its finish now available by default. `logLaunchLink` option is removed from the config. ### Security - Updated versions of vulnerable packages (@babel/traverse). diff --git a/README.md b/README.md index 5286e68..61add7a 100755 --- a/README.md +++ b/README.md @@ -90,7 +90,6 @@ The full list of available options presented below. | skippedIssue | Optional | true | reportportal provides feature to mark skipped tests as not 'To Investigate'.
Option could be equal boolean values:
*true* - skipped tests considered as issues and will be marked as 'To Investigate' on reportportal.
*false* - skipped tests will not be marked as 'To Investigate' on application. | | debug | Optional | false | This flag allows seeing the logs of the client-javascript. Useful for debugging. | | launchId | Optional | Not set | The _ID_ of an already existing launch. The launch must be in 'IN_PROGRESS' status while the tests are running. Please note that if this _ID_ is provided, the launch will not be finished at the end of the run and must be finished separately. | -| logLaunchLink | Optional | false | This flag allows print the URL of the Launch of the tests in console. | | restClientConfig | Optional | Not set | The object with `agent` property for configure [http(s)](https://nodejs.org/api/https.html#https_https_request_url_options_callback) client, may contain other client options eg. [`timeout`](https://github.com/reportportal/client-javascript#timeout-30000ms-on-axios-requests).
Visit [client-javascript](https://github.com/reportportal/client-javascript) for more details. | | isLaunchMergeRequired | Optional | false | This flag determines whether to create temp files with the UUIDs of started launches and allow them to be merged using [`client-javascript`'s `mergeLaunches` method](https://github.com/reportportal/client-javascript#mergelaunches). Temp file format: `rplaunch-${launch_uuid}.tmp`. | | launchUuidPrint | Optional | false | Whether to print the current launch UUID. | diff --git a/__tests__/mocks/reportportal-client.mock.js b/__tests__/mocks/reportportal-client.mock.js index 5d85ed1..55efe48 100644 --- a/__tests__/mocks/reportportal-client.mock.js +++ b/__tests__/mocks/reportportal-client.mock.js @@ -20,7 +20,6 @@ const reporterOptions = { project: 'projectName', launch: 'launcherName', description: 'description', - logLaunchLink: true, attributes: [ { key: 'YourKey', diff --git a/index.js b/index.js index 7dfda0c..908d993 100644 --- a/index.js +++ b/index.js @@ -111,12 +111,6 @@ class JestReportPortal { } const { promise } = this.client.finishLaunch(this.tempLaunchId); - if (this.reportOptions.logLaunchLink === true) { - promise.then((response) => { - console.log(`\nReportPortal Launch Link: ${response.link}`); - }); - } - promiseErrorHandler(promise); await promise; } diff --git a/utils/objectUtils.js b/utils/objectUtils.js index ffda06c..dbd0301 100644 --- a/utils/objectUtils.js +++ b/utils/objectUtils.js @@ -93,7 +93,6 @@ const getAgentOptions = (options = {}) => { debug: options.debug, restClientConfig: options.restClientConfig, launchId: process.env.RP_LAUNCH_ID || options.launchId, - logLaunchLink: options.logLaunchLink, isLaunchMergeRequired: options.isLaunchMergeRequired, launchUuidPrint: options.launchUuidPrint, launchUuidPrintOutput: options.launchUuidPrintOutput,