Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Pale" blocks cause falses #1920

Closed
olekolek1000 opened this issue Jan 2, 2025 · 8 comments · Fixed by retrooper/packetevents#1108
Closed

"Pale" blocks cause falses #1920

olekolek1000 opened this issue Jan 2, 2025 · 8 comments · Fixed by retrooper/packetevents#1108
Labels
false positive False positive packetevents Caused by PacketEvents simulation Related to Simulation / Prediction engine

Comments

@olekolek1000
Copy link

Describe the false positive and how to replicate it

The player triggers simulation false positive while trying to step on a pale oak fence.

image

Grim Log

https://paste.grim.ac/eyuj81e

Server version

Paper 1.21.4-15-master@bb76819

Client version

1.21.4

Plugins

CoreProtect, Essentials, GrimAC, ProtocolLib
@olekolek1000 olekolek1000 added false positive False positive simulation Related to Simulation / Prediction engine labels Jan 2, 2025
@Weigurde
Copy link

Weigurde commented Jan 2, 2025

have you tried this on the latest commit?

@SamB440 SamB440 added the packetevents Caused by PacketEvents label Jan 2, 2025
@SamB440
Copy link
Contributor

SamB440 commented Jan 2, 2025

Packetevents issue by not including it in the block tag

@olekolek1000
Copy link
Author

Yes, it still happens in the newest commit (branch 2.0, #1ce5a53)

@spring-dependency-management
Copy link
Contributor

Packetevents issue by not including it in the block tag

idk, it seems to be there, but the false persists? https://github.com/retrooper/packetevents/blob/3d2a872de11733f66b7195a7e12320d39ebd11e4/api/src/main/java/com/github/retrooper/packetevents/protocol/world/states/defaulttags/BlockTags.java#L322

@spring-dependency-management
Copy link
Contributor

ahh they didnt set .isShapeExceedsCube(true) on pale oak fence https://github.com/retrooper/packetevents/blob/3d2a872de11733f66b7195a7e12320d39ebd11e4/api/src/main/java/com/github/retrooper/packetevents/protocol/world/states/type/StateTypes.java#L1181

Merged
@SamB440 SamB440 changed the title Cannot step on "Pale Oak" fence "Pale" blocks cause falses Jan 13, 2025
@Kadeluxe
Copy link
Contributor

So... There is a PR in packet events, is there anything else we can do to fix this?

@SamB440 SamB440 mentioned this issue Jan 18, 2025
Closed
@SamB440 SamB440 marked this as a duplicate of #1953 Jan 18, 2025
@StKillReal
Copy link

When player jump onto pale oak sign
Image

Image

@SamB440
Copy link
Contributor

SamB440 commented Jan 24, 2025

Upstream has merged a bunch of block state fixes, this should be fixed when CI rebuilds on the latest packetevents at some point.

@SamB440 SamB440 closed this as completed Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
false positive False positive packetevents Caused by PacketEvents simulation Related to Simulation / Prediction engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix pale oak materials spring-dependency-management/packetevents
6 participants
@SamB440 @olekolek1000 @StKillReal @Kadeluxe @Weigurde @spring-dependency-management