Cannot read property 'length' of undefined

[lucasssfigueredo]

Hi.

I just added this block to my release template and started getting this error
tasklog_9.log
:

Global list of CS ({{commits.length}})
{{#forEach commits}} {{#if isFirst}}### Associated commits{{/if}}
** ID{{this.id}}**
Message: {{this.message}}
Commited by: {{this.author.displayName}}
FileCount: {{this.changes.length}} {{#forEach this.changes}}
File path (TFVC or TfsGit): {{this.item.path}}
File filename (GitHub): {{this.filename}}
{{/forEach}} {{/forEach}}

Any ideas?

[rfennell]

I suspect the {{this.changes.length}} is the issue and the changes property is null for one or more commits in the loop

The immediate test is to try with this line removed, make sure it runs through.

After that, you will want to look at the data to see why there is an issue. You have a few options here

• Use {{json this}} in the loop, or elsewhere, to dump objects to the output file
• Use the various DUMP parameters as detailed in the WIKI to dump the raw json output object somewhere
• Or test with the local test harness, so you don't need to run a build each time.

The issue will be

• Bad property name
• Or the need to add an if no null guard around the line, if it is sometimes present and sometimes not.

[lucasssfigueredo]

Hi Richard.

Thanks again for the prompt response.

Apparently, I have commits but I don't have the changes inside, any ideas why?

[rfennell]

You have found a bug.

The API call buildApi.getBuildChanges(teamProject, build.id) gets the details of the headline commit, but not the actual list of files. I have to make another set of calls to do this.

The issue is that the task has a number of code paths

• Build (YAML or Classic)
• Multi-Stage YAML
• Classic Release (initial run) < you are using this
• Classic Release (another run)
  and I there are probably more edge case paths.

The code to get the commit details are not run on the code path you are using. This is logged as #974. I will get onto it ASAP

[lucasssfigueredo]

Hi Richard, sorry but I´m struggling a bit here.

I'm trying to check if changeType is 144(Deleted), but I'm receiving an error:

Expecting 'ID', 'STRING', 'NUMBER', 'BOOLEAN', 'UNDEFINED', 'NULL', 'DATA', got 'INVALID']

{{#forEach commits}}
{{#if isFirst}}### Deleted files{{/if}}
{{#forEach this.changes}}
{{#if (eq(this.changeType 144))}}
{{this.changeType}} - {{this.item.path}}
{{/if}}
{{/forEach}}
{{/forEach}}

Already tried '144'.
Also tried to use {{#if (compare(this.changeType '=' 144))}}

[rfennell]

How about {{#if (contains(this.changeType '144'))}}

[lucasssfigueredo]

Same error. :(

Looks like this.changeType is none of the expected types

[lucasssfigueredo]

Managed now

Removed internal parentheses
{{#if (eq this.changeType 144)}}

[rfennell]

Yes I looked at the raw json (by looking at a dumped payload using the appropriate flags) and it is an Int not a string