Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create and publish a V0.0.1 document release #115

Open
axel-h opened this issue Dec 6, 2024 · 9 comments
Open

Create and publish a V0.0.1 document release #115

axel-h opened this issue Dec 6, 2024 · 9 comments

Comments

@axel-h
Copy link
Contributor

axel-h commented Dec 6, 2024

Now that #112 has been merged, there should be a first release of the document with the goal to have this also on the RISC-V docs website https://lf-riscv.atlassian.net/wiki/spaces/HOME/pages/16154769/RISC-V+Technical+Specifications#Non-ISA-Specifications. Could still be marked as draft or prerelease.

@wmat
Copy link
Contributor

wmat commented Dec 6, 2024

Is this manual an artificate under the toolchain TG?

@apazos
Copy link
Collaborator

apazos commented Dec 7, 2024

@axel-h , we discussed your CI workflow request at the last Toolchain SIG meeting on 11/21 and we agreed on adding a CI workflow, but not an official release yet.

In addition, the spec versioning scheme will change with the new BoD Policy, we should wait until it is settled.

Can you explain your urgency to have a first release?

Adding @cmuellner to comment as well.

@axel-h
Copy link
Contributor Author

axel-h commented Dec 7, 2024

There is no urgency, it would just be nice to have something one can refer to in other document - besides just a commit ID in a repository.

@axel-h
Copy link
Contributor Author

axel-h commented Dec 7, 2024

It seems merging the workflow was not enough, this also needs a workflow approval somewhere. The CI job
https://github.com/riscv-non-isa/riscv-asm-manual/actions/runs/12198852957/job/34031552715 tried to upload the artifacts after a push to main to https://github.com/riscv-non-isa/riscv-asm-manual/releases/tag/untagged-b05b87e58d03d44b1e68, but this gives a 404 and the draft documents for latest maindo not show up under https://github.com/riscv-non-isa/riscv-asm-manual/releases. It workes in my fork at https://github.com/axel-h/riscv-asm-manual/releases when testing this. Could you have a look at "Settings" -> "Actions" -> ""General" -> "Workflow permissions", that the GITHUB_TOKEN has read and write access. Default might be just read access.

@wmat
Copy link
Contributor

wmat commented Dec 9, 2024 via email

@cmuellner
Copy link
Collaborator

I really appreciate the attempts to get CI/CD up and running.

However, I think we should copy from the psABI repo, as the workflow there has shown to work quite well.
We might make little adjustments (where necessary) or use more recent versions of external jobs, but overall, we should just do what can be found there: https://github.com/riscv-non-isa/riscv-elf-psabi-doc/blob/master/.github/workflows/build.yml

@axel-h, if you are interested then feel free to adjust this repo's workflow accordingly. We may also look at https://github.com/riscv-non-isa/riscv-elf-psabi-doc/blob/master/.github/workflows/remove-old-artifacts.yml.

For the particular issue that is discussed here, the psABI workflow file does what is expected by the "Upload release asset" step of the "draft-release" step. See https://github.com/riscv-non-isa/riscv-elf-psabi-doc/blob/master/.github/workflows/build.yml#L59.

@wmat
Copy link
Contributor

wmat commented Dec 9, 2024

In this particular instance the build fails due to an error in the PDF theme. I've fixed the error in docs-resources and am trying to update the submodule now, which is being stubborn for some reason. If necessary, I'll just delete it and start from scratch.

@axel-h
Copy link
Contributor Author

axel-h commented Dec 9, 2024

The build worked, we have an artifacts zip in the action with a nice PDF. Just the draft release is not visible. I will have a look into this, as this also looks a bit odd in my fork. Seems the action needs some fine tuning. I had a look at the other project actions when creating this, seems a subtle detail that I got wrong there.

@wmat please push the template fix then also if this is another improvement.

@cmuellner
Copy link
Collaborator

@axel-h, I've created a PR to add the CI/CD scripts from the docs-template repo (https://github.com/riscv/docs-spec-template/tree/main/.github). See #118.

To avoid fragmentation, I also filed similar PRs to harmonize the CI/CD scripts of the C-API and the Toolchain Conventions as well. See riscv-non-isa/riscv-toolchain-conventions#66 and riscv-non-isa/riscv-c-api-doc#98.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants