From 5bf336d101bb2ab18c255623db43810b3b094757 Mon Sep 17 00:00:00 2001 From: bibhuprasad-hcl <161687009+bibhuprasad-hcl@users.noreply.github.com> Date: Tue, 4 Jun 2024 16:02:39 -0400 Subject: [PATCH] [PDPI] Remove broken & redundant test. (#173) * [PDPI] Remove broken & redundant test. --------- Co-authored-by: smolkaj Co-authored-by: kishanps --- p4_pdpi/testing/rpc_test_runner.cc | 5 ----- p4_pdpi/testing/testdata/rpc.expected | 16 ---------------- 2 files changed, 21 deletions(-) diff --git a/p4_pdpi/testing/rpc_test_runner.cc b/p4_pdpi/testing/rpc_test_runner.cc index 98bf396c..1cbbdb45 100644 --- a/p4_pdpi/testing/rpc_test_runner.cc +++ b/p4_pdpi/testing/rpc_test_runner.cc @@ -355,11 +355,6 @@ static void RunReadRequestTests(pdpi::IrP4Info info) { entities { table_entry {} } entities { table_entry {} } )pb")); - RunPiReadRequestTest(info, "valid", - gutil::ParseProtoOrDie(R"pb( - device_id: 10 - entities { table_entry {} } - )pb")); // There are no invalid IR read requests, so no RunIrReadRequestTest is // needed. diff --git a/p4_pdpi/testing/testdata/rpc.expected b/p4_pdpi/testing/testdata/rpc.expected index 4d03e910..44760c3e 100644 --- a/p4_pdpi/testing/testdata/rpc.expected +++ b/p4_pdpi/testing/testdata/rpc.expected @@ -49,22 +49,6 @@ entities { --- PI is invalid/unsupported: UNIMPLEMENTED: Only wildcard reads of all table entries are supported. Only 1 entity is supported. Found 2 entities in read request. -========================================================================= -ReadRequest test: valid -========================================================================= - ---- PI (Input): -device_id: 10 -entities { - table_entry { - } -} - -TEST FAILED (DO NOT SUBMIT) -TEST NAME: ReadRequest test: valid -FAILURE REASON: Expected PI to be invalid (valid PI should instead be tested using RunGenericPdTest. - - ========================================================================= ReadRequest test: no meter, no counter =========================================================================