Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide better APIs for working with models that have many inputs / outputs #71

Open
robertknight opened this issue Mar 30, 2024 · 0 comments

Comments

@robertknight
Copy link
Owner

The current APIs for running models in RTen are annoying to use if a model has many inputs or outputs. The current APIs require a list of (NodeId, Input) tuples to be passed for the input, and a list of NodeIds of outputs. It would however be more ergonomic if:

  • The inputs/outputs could be specified as names, without requiring the NodeId lookup step first
  • There was a convenient way to build up the inputs as a hash map
  • Outputs could easily be retrieved by name rather than index

This issue originally came up when porting the Tacotron2 TTS demo from https://github.com/xd009642/xd-tts/ to RTen. See page 38 of https://github.com/xd009642/xd-tts/blob/master/slides/slides.pdf for an example of why this matters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant