Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HttpService missing HttpEnabled type #1189

Closed
fisherjacobc opened this issue Mar 1, 2024 · 5 comments
Closed

HttpService missing HttpEnabled type #1189

fisherjacobc opened this issue Mar 1, 2024 · 5 comments

Comments

@fisherjacobc
Copy link
Contributor

I noticed while working on a project that the HttpEnabled property is missing from HttpService

@Dionysusnu
Copy link
Contributor

Is this actually wrong? I'm trying to read HttpEnabled in studio, both in game testing and with a plugin, but both are erroring saying they need LocalUser permissions. What makes you believe this should be added to @rbxts/types?

@fisherjacobc
Copy link
Contributor Author

Oh? Maybe you're right, I know you can set it in the command bar (which i presumed had the same access capabilities of plugins), but I thought you could read it in a regular script to check if it was enabled. So that seems like an oversight on my end (for not realizing you can't even read it), and also on roblox's end (for not letting us read it). I guess I would have to just make an http request inside a pcall/try-catch and use that to determine if HttpService is enabled.

@Dionysusnu
Copy link
Contributor

Dionysusnu commented Mar 5, 2024

Oh? Maybe you're right, I know you can set it in the command bar (which i presumed had the same access capabilities of plugins)

The command bar has a slightly higher permission. In the API dump, it's LocalUserSecurity, whereas plugins have PluginSecurity.

I guess I would have to just make an http request inside a pcall/try-catch and use that to determine if HttpService is enabled.

Yeah, pretty much.

@fisherjacobc fisherjacobc closed this as not planned Won't fix, can't repro, duplicate, stale Mar 5, 2024
@Dionysusnu
Copy link
Contributor

They're listening
HttpEnabled just got changed to be None security for reading. MaximumADHD/Roblox-Client-Tracker@dfff1f8#diff-099be3b8c79c155bf018fa90fb579a95e4d5f6a19476caf5b195834ecf1497d4R45158

Since the API dump reflects this correctly, an override in the generator is not necessary, so the linked PR can still be closed.

@fisherjacobc
Copy link
Contributor Author

they're in my walls, they're in my walls help
good to know! will do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants