Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version number #66

Open
schriftgestalt opened this issue Apr 5, 2018 · 16 comments
Open

Version number #66

schriftgestalt opened this issue Apr 5, 2018 · 16 comments

Comments

@schriftgestalt
Copy link
Contributor

Is there a version number somewhere? If not, can we add one?

@typemytype
Copy link
Member

there is https://github.com/typesupply/vanilla/blob/master/setup.py#L24 :)
but not a good one...

@schriftgestalt
Copy link
Contributor Author

Something like:

import vanilla
print vanilla.__version__

would be nice.

@anthrotype
Copy link
Member

anthrotype commented Apr 5, 2018

yes, what Georg proposes is standard for python modules.

but one can still get the version string from metadata that is installed along with a package, using pkg_resources (part of setuptools), like this:

from pkg_resources import get_distribution, DistributionNotFound
try:
    version = get_distribution("vanilla").version
except DistributionNotFound:
    # package is not installed, or is missing dist-info metadata
    ...

@schriftgestalt
Copy link
Contributor Author

I send a pull request. I set the version to 0.1, for now.

@schriftgestalt
Copy link
Contributor Author

On a second though, we could use an integer only version number (like firefox) as there are no releases. So we can just increment the number when there is a change and we don’t need to decide if it is a minor or major change.

@typemytype
Copy link
Member

quick thought: the commit number is also fine for me..

@schriftgestalt
Copy link
Contributor Author

If that plays well with branches?

@anthrotype
Copy link
Member

if you want to use the same string for the setup.py version, then it should conform to the https://www.python.org/dev/peps/pep-0440/

Maybe you don't care at all about distributing vanilla via the normal python distribution channels for you only use it in embedded apps, in which case you're free to do whatever.

I personally prefer a PEP440-compatible SemVer style, to not break user expectations too much.

@anthrotype
Copy link
Member

FWIW in booleanOperations we use setuptools_scm, that computes the setup.py version automatically using git.

@justvanrossum
Copy link
Collaborator

Let's stick to a simple major.minor scheme. I also propose to call what we currently have 1.0 :)

@benkiel
Copy link
Member

benkiel commented Apr 5, 2018

Agree. It's been around for long enough to be 1.0.

@gferreira
Copy link
Contributor

hello from 2019 :)

let’s finally change the version number? in honor of the recent auto layout updates.

@typemytype
Copy link
Member

+1 for a jump

@benkiel
Copy link
Member

benkiel commented Oct 24, 2019

Agree! 1.0 it should be!

@benkiel
Copy link
Member

benkiel commented Oct 24, 2019

And, we should put it on pipy, though there is a vanilla already there.

@form-follows-function
Copy link
Contributor

And, we should put it on pipy, though there is a vanilla already there.

Pushing this a bit more. To get around the existing vanilla package, I would suggest a pip naming like vanilla-ui or vanilla-macos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants