-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version number #66
Comments
there is https://github.com/typesupply/vanilla/blob/master/setup.py#L24 :) |
Something like:
would be nice. |
yes, what Georg proposes is standard for python modules. but one can still get the version string from metadata that is installed along with a package, using from pkg_resources import get_distribution, DistributionNotFound
try:
version = get_distribution("vanilla").version
except DistributionNotFound:
# package is not installed, or is missing dist-info metadata
... |
I send a pull request. I set the version to |
On a second though, we could use an integer only version number (like firefox) as there are no releases. So we can just increment the number when there is a change and we don’t need to decide if it is a minor or major change. |
quick thought: the commit number is also fine for me.. |
If that plays well with branches? |
if you want to use the same string for the setup.py version, then it should conform to the https://www.python.org/dev/peps/pep-0440/ Maybe you don't care at all about distributing vanilla via the normal python distribution channels for you only use it in embedded apps, in which case you're free to do whatever. I personally prefer a PEP440-compatible SemVer style, to not break user expectations too much. |
FWIW in booleanOperations we use setuptools_scm, that computes the setup.py version automatically using git. |
Let's stick to a simple major.minor scheme. I also propose to call what we currently have 1.0 :) |
Agree. It's been around for long enough to be 1.0. |
hello from 2019 :) let’s finally change the version number? in honor of the recent auto layout updates. |
+1 for a jump |
Agree! 1.0 it should be! |
And, we should put it on pipy, though there is a vanilla already there. |
Pushing this a bit more. To get around the existing vanilla package, I would suggest a pip naming like |
Is there a version number somewhere? If not, can we add one?
The text was updated successfully, but these errors were encountered: