Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: Add presets for with/without combinations #2

Open
nazunalika opened this issue Jul 12, 2022 · 5 comments
Open

RFE: Add presets for with/without combinations #2

nazunalika opened this issue Jul 12, 2022 · 5 comments
Labels
enhancement New feature or request priority: medium This issue or pull request is of medium priority

Comments

@nazunalika
Copy link
Member

It should be possible to use build presets for with/without combinations. For example, to do a "plus" build for Thunderbird, we need to have with rlplus, which will provide a thunderbird plus build. This would also allow us to turn on openldap-server builds without modifying the spec file.

@nazunalika nazunalika added priority: medium This issue or pull request is of medium priority enhancement New feature or request labels Jul 12, 2022
@nazunalika nazunalika changed the title Request for Enhancement: Add presets for with/without combinations RFE: Add presets for with/without combinations Jul 12, 2022
@NeilHanlon NeilHanlon moved this to Backlog in Peridot Jul 14, 2022
@NeilHanlon NeilHanlon moved this from Backlog to Ready in Peridot Jul 14, 2022
@NeilHanlon NeilHanlon moved this from Ready to Backlog in Peridot Jul 14, 2022
@nazunalika
Copy link
Member Author

We've received requests for a plus version of thunderbird. Resolving this will help with this request.

@mstg
Copy link
Member

mstg commented Dec 8, 2022

https://git.rockylinux.org/rocky/peridot-rocky/-/blob/r9/extraoptions.cfg#L5
So we do support with/without, but not as a preset per-se. Enabling/disabling that option requires a catalog sync each time which is tedious.
If keeping the with option enabled won't make it RHEL incompatible besides emitting new artifacts, then it should be good to go, otherwise we can look into the preset option and prioritize it.

@nazunalika
Copy link
Member Author

The issue is with thunderbird in this example is it would make it completely incompatible with upstream. We patch it to allow the ability to turn on rlplus (which turns on pgp and librnp), default is that it builds just like upstream does. Thunderbird for example is built twice for Rocky Linux 8 in koji. One is using default settings, the other the rlplus conditional is turned on.

image

This is because the first one is compatible with upstream and the second turns on a feature that spits out additional packages and both are then depending on each other. That incompatible version is then sent off into plus.

The only alternative I tried to think about was having thunderbird-plus in staging/src but keep the thunderbird name for the packages that come out (and it'll keep .plus in the dist tag). But I don't think srpmproc would be a fan of this (admittedly kind of poor) idea.

@nazunalika
Copy link
Member Author

nazunalika commented Dec 8, 2022

Another idea could be maybe having a separate "plus" project to get around this, but maybe that's too much? Especially since openldap is one full build for example, we just turn on a switch that Red Hat turns off.

@mstg
Copy link
Member

mstg commented Dec 8, 2022

Ah, I see. Due to the nature of the flag, supporting variants/presets (aka multiple instance of same package with different flags) seems like the most logical choice. I can't imagine supporting that scenario would require too much change considering how we keep internal state at the moment. Let's plan this out and get back to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority: medium This issue or pull request is of medium priority
Projects
Status: Backlog
Development

No branches or pull requests

2 participants