Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamically color sample types #14

Closed
romunov opened this issue Oct 7, 2017 · 5 comments
Closed

dynamically color sample types #14

romunov opened this issue Oct 7, 2017 · 5 comments
Assignees

Comments

@romunov
Copy link
Owner

romunov commented Oct 7, 2017

Right now, sample types are hard coded. This is not acceptable (work for our sample data right now) and the restriction needs to be relaxed.

The idea is that this should be some sort of a form, where user could change colors for sample types. For example, someone might fancy to color mortality samples with a bright red color.

I'm thinking maybe incorporating a settings page with colourInput drawn dynamically. Perhaps there's a better, more compact solution

@romunov
Copy link
Owner Author

romunov commented Oct 7, 2017

I wonder, is it possible to change legend opacity to match that of the input/slider at the top right corner?

@romunov romunov reopened this Oct 8, 2017
@romunov
Copy link
Owner Author

romunov commented Oct 8, 2017

Adding a settings page and a tab for picking colors using colourpicker package should do the trick. Just have color mapping of sample types in a data.frame and update based on input$picked_color.

@romunov romunov self-assigned this Oct 8, 2017
@romunov
Copy link
Owner Author

romunov commented Oct 8, 2017

BTW, @charlie86 if you want to participate on this project, feel free to contact me ([email protected]) and I'll add you to the list. It will save us all the pull request drivel.

@romunov
Copy link
Owner Author

romunov commented Oct 9, 2017

For some reason, I can't get solution using colourpicker to work. @charlie86 can you have a look at this? If you turn this on/off you will notice that the list does not work when TRUE. What's pissing me off is that it works when the list is created manually. I've compared outputs and I can't really find anything substantially different.

@romunov
Copy link
Owner Author

romunov commented Oct 9, 2017

The problem was that I was using a limited palette for automatic generation of inputs and "square" for the manual one. Since limited palette doesn't hold brewer specified colors, it reverts to black. A warning would be nice...

@romunov romunov closed this as completed in f7dc140 Oct 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant