From 9edfdf04a0dc224fc362fcee655ef1c43494972b Mon Sep 17 00:00:00 2001 From: Wiktor Bajor Date: Tue, 12 Nov 2024 17:45:01 +0100 Subject: [PATCH 1/3] Add DynamicComponentValues msg --- control_msgs/CMakeLists.txt | 1 + control_msgs/msg/DynamicComponentValues.msg | 6 ++++++ 2 files changed, 7 insertions(+) create mode 100644 control_msgs/msg/DynamicComponentValues.msg diff --git a/control_msgs/CMakeLists.txt b/control_msgs/CMakeLists.txt index be3bda8..09d7e61 100644 --- a/control_msgs/CMakeLists.txt +++ b/control_msgs/CMakeLists.txt @@ -38,6 +38,7 @@ set(msg_files msg/SingleDOFStateStamped.msg msg/SteeringControllerStatus.msg msg/SpeedScalingFactor.msg + msg/DynamicComponentValues.msg ) set(action_files diff --git a/control_msgs/msg/DynamicComponentValues.msg b/control_msgs/msg/DynamicComponentValues.msg new file mode 100644 index 0000000..2bebb27 --- /dev/null +++ b/control_msgs/msg/DynamicComponentValues.msg @@ -0,0 +1,6 @@ +std_msgs/Header header + +# List of component names, e.g. ["flange_analog_IOs", "flange_vacuum"] +string[] component_names +# Key-value pairs representing interfaces and their corresponding values for each component listed in `component_names` +InterfaceValue[] interface_values From c83f701410c804ba501f836a674fa0829cfc488a Mon Sep 17 00:00:00 2001 From: Wiktor Bajor Date: Thu, 14 Nov 2024 12:24:53 +0100 Subject: [PATCH 2/3] Apply review suggestions --- control_msgs/CMakeLists.txt | 2 +- control_msgs/msg/DynamicComponentValues.msg | 6 ------ control_msgs/msg/DynamicInterfaceGroupValues.msg | 6 ++++++ 3 files changed, 7 insertions(+), 7 deletions(-) delete mode 100644 control_msgs/msg/DynamicComponentValues.msg create mode 100644 control_msgs/msg/DynamicInterfaceGroupValues.msg diff --git a/control_msgs/CMakeLists.txt b/control_msgs/CMakeLists.txt index 09d7e61..52240e0 100644 --- a/control_msgs/CMakeLists.txt +++ b/control_msgs/CMakeLists.txt @@ -21,6 +21,7 @@ find_package(trajectory_msgs REQUIRED) set(msg_files msg/AdmittanceControllerState.msg + msg/DynamicInterfaceGroupValues.msg msg/DynamicInterfaceValues.msg msg/DynamicJointState.msg msg/GripperCommand.msg @@ -38,7 +39,6 @@ set(msg_files msg/SingleDOFStateStamped.msg msg/SteeringControllerStatus.msg msg/SpeedScalingFactor.msg - msg/DynamicComponentValues.msg ) set(action_files diff --git a/control_msgs/msg/DynamicComponentValues.msg b/control_msgs/msg/DynamicComponentValues.msg deleted file mode 100644 index 2bebb27..0000000 --- a/control_msgs/msg/DynamicComponentValues.msg +++ /dev/null @@ -1,6 +0,0 @@ -std_msgs/Header header - -# List of component names, e.g. ["flange_analog_IOs", "flange_vacuum"] -string[] component_names -# Key-value pairs representing interfaces and their corresponding values for each component listed in `component_names` -InterfaceValue[] interface_values diff --git a/control_msgs/msg/DynamicInterfaceGroupValues.msg b/control_msgs/msg/DynamicInterfaceGroupValues.msg new file mode 100644 index 0000000..22d5994 --- /dev/null +++ b/control_msgs/msg/DynamicInterfaceGroupValues.msg @@ -0,0 +1,6 @@ +std_msgs/Header header + +# List of interface group names , e.g. ["flange_analog_IOs", "flange_vacuum"] +string[] interface_group_names +# Key-value pairs representing interfaces and their corresponding values for each interface group listed in `interface_group_names` +InterfaceValue[] interface_values From 43b9463be15738f62399a9a7410005f4130a30b2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christoph=20Fr=C3=B6hlich?= Date: Fri, 15 Nov 2024 15:05:09 +0100 Subject: [PATCH 3/3] Shorten the field name --- control_msgs/msg/DynamicInterfaceGroupValues.msg | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/control_msgs/msg/DynamicInterfaceGroupValues.msg b/control_msgs/msg/DynamicInterfaceGroupValues.msg index 22d5994..ff65ba6 100644 --- a/control_msgs/msg/DynamicInterfaceGroupValues.msg +++ b/control_msgs/msg/DynamicInterfaceGroupValues.msg @@ -1,6 +1,6 @@ std_msgs/Header header # List of interface group names , e.g. ["flange_analog_IOs", "flange_vacuum"] -string[] interface_group_names -# Key-value pairs representing interfaces and their corresponding values for each interface group listed in `interface_group_names` +string[] interface_groups +# Key-value pairs representing interfaces and their corresponding values for each interface group listed in `interface_groups` InterfaceValue[] interface_values