Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

license in transmission_interface #326

Closed
pholthaus opened this issue Apr 18, 2018 · 8 comments
Closed

license in transmission_interface #326

pholthaus opened this issue Apr 18, 2018 · 8 comments

Comments

@pholthaus
Copy link
Contributor

In package.xml of transmission_interface, the license is specified as "modified bsd" while that seems to be the standard 3-clause BSD license as in the other packages in this repository as well. This can lead to problems when automatically parsing the file, such as
ros/ros-overlay#567

Could you please unify the specification in package.xml to match the LICENSE file? Thank you

@bmagyar
Copy link
Member

bmagyar commented Apr 20, 2018

Thanks for the heads up, you are right!

Could you please parse the rest of the packages, also the ones at https://github.com/ros-controls/ros_controllers/ ? I'd like to resolve all at once.

@pholthaus
Copy link
Contributor Author

There were only two package.xml files in each repository. I have created PRs fixing those two. HTH

@bmagyar
Copy link
Member

bmagyar commented Apr 20, 2018

Thank you!

@pholthaus
Copy link
Contributor Author

Thank you for the quick response!

@pholthaus
Copy link
Contributor Author

Could you please backport these fixes to kinetic?

@pholthaus
Copy link
Contributor Author

I'm sorry to still commenting on this, but in kinetic-devel the issue still exists.

@bmagyar
Copy link
Member

bmagyar commented Apr 20, 2018 via email

@pholthaus
Copy link
Contributor Author

Perfect, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants