-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Officially release kinetic refactor #245
Comments
@miguelprada @ipa-nhg @ipa-mdl FYI. |
Some updates done:
For the readme of this repository I suggest to move the improvements section to a new markdown file or, at least, to the end of the readme. Also everything related to API, parameters and configuration usually is part of the ROS wiki and not the readme of the repo. @gavanderhoorn what do you think? Basically for the readme we can take other ros-i repo readme as template, what about fanuc? |
great. Thanks.
yes, perhaps we can even create a
I'm not against having it here in the readme, although I do agree information like that is typically part of the wiki pages for a package. I'm not sure, what do you think @miguelprada? Advantage of having that information here on GH is that we keep everything in one place. We might even consider converting some of the readme content into proper documentation (using sphinx or something similar). Then refer to it from the wiki, similar to other packages (like MoveIt fi).
I'm ok with keeping the readme simple and similar to others. Separating-out the extensive sections about parameters, topics and additional functionality would already help significantly. |
@miguelprada @gavanderhoorn I would like to move this forward, concretely update documentation and release asap the repos. What about docu?
opinions? |
Sounds good. It's going to be a challenge to make it really minimal, considering there's three different "modes" of execution for this driver, though 😅 Are you willing to start with this? You need help with anything in particular? |
This would also require a new |
If with minimal you mean: a readme similar to other ros-industrial repositories without all the information on configuration and compatible system etc, then that makes sense to me.
With ROS 2 in mind (and the changes to how documentation is going to be hosted and viewed by users): may I suggest to actually keep that information here in the repository, but just break up the current readme into a few files, one per 'subject'? That would accomplish the same thing, we can link to it from the ROS wiki, but would make it easier to migrate that text to whatever ends up being the platform of choice for ROS 2 (which at the moment is sphinx + rst).
I changed my mind about that: the thesis will be hosted by DTU, we can link to it. It's more than 1.5MB, isn't going to change and a big binary blob, so I would rather not host it in this git repository. |
@miguelprada wrote:
|
I'm closing this as we've officially deprecated this package. Refer to the announcement on ROS Discourse. |
This package will therefore not be released through the ROS buildfarm. |
This is a meta-issue to track and coordinate the release of the
kinetic-devel
refactor.Tasks to be completed before that can be done:
ur_modern_driver
exclusivelyreadme
):kinetic-devel
by default (it also builds on Indigo)indigo-devel
(currentmaster
) if the old version is preferredros_control
and low bandwidth traj follower variantskinetic-devel
)And after that:
ros-industrial
categoryur_driver
properly (package manifest)ur_modern_driver
node (perhaps consider forwardingur_driver
launch files tour_modern_driver
launch files)The text was updated successfully, but these errors were encountered: