Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for boolean datatype #268

Open
mathias-luedtke opened this issue Feb 14, 2018 · 3 comments
Open

Add support for boolean datatype #268

mathias-luedtke opened this issue Feb 14, 2018 · 3 comments

Comments

@mathias-luedtke
Copy link
Member

Support for boolean data could be added for SDOs.
However, the PDO granularity will be kept at 8, so single bits cannot be mapped for performance reasons.

The following should be suffiicient to get basic support:

  1. add data type enum
  2. add parser
  3. add C type to lookup, bool?
  4. prevent mapping of objects with type 1
  5. testing

It should more or less straight-forward, but needs some testing with devices that offer bit-access.

@rostest
Copy link

rostest commented Feb 18, 2019

To support further can devices and eds-files for a customer, the boolean datatype is required soon. An implementation of 1-bit SDOs would be extremly helpfull. Would it be possible in the near future?

It should more or less straight-forward, but needs some testing with devices that offer bit-access.

I have access to such a device and would like to help. If f.e. some beta-version is available for (pre-)testing, please give me a hint. Many thanks and best regards!

@mathias-luedtke
Copy link
Member Author

Would it be possible in the near future?

Yes, if someone implements it. I don't have time (and no device) to do it.
That's why I added the "help wanted" label..

@lkm1321
Copy link

lkm1321 commented Aug 27, 2020

Hi, I actually just added support for booleans in my fork, because my EDS file wasn't parsing because of boolean. I don't have the device in question with me at the moment, but I verified that:

  1. EDS file containing booleans are parsed without throwing a std::bad_cast
  2. When the user requests the object to be published, it's registered as an std_msgs/Bool topic

I'm happy to create a PR. Does it add on to melodic or melodic-devel?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants