Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to actions/checkout@v4, enable dependabot #6

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Apr 23, 2024

No description provided.

@cottsay cottsay requested a review from nuclearsandwich April 23, 2024 18:57
@cottsay cottsay self-assigned this Apr 23, 2024
Copy link

@j-rivero j-rivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, just left a small comment for using version on GitHub actions.

@@ -10,7 +11,7 @@ jobs:
build-ros-dev-tools:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A personal choice: these I tend to replace the version tags on GitHub actions by the commit hash to help with possible supply chain attacks. Leave that up to you here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof, we're not doing that anywhere right now, and I'm pretty sure it isn't compatible with dependabot. We should bring that up at the next infra meeting if it's something you think is worth pursuing.

@cottsay cottsay merged commit 316bc45 into latest Sep 27, 2024
4 checks passed
@cottsay cottsay deleted the cottsay/actions branch September 27, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants