From 79bd5c299d445b34e3725764af4f222db0a1c7cf Mon Sep 17 00:00:00 2001 From: Scott K Logan Date: Fri, 11 Oct 2024 11:55:33 -0500 Subject: [PATCH 1/5] Include much more information in the intro block Co-authored-by: kscottz --- rosdistro_reviewer/submitter/github.py | 25 +++++++++++++++++++++++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff --git a/rosdistro_reviewer/submitter/github.py b/rosdistro_reviewer/submitter/github.py index 1d3f2a1..7468876 100644 --- a/rosdistro_reviewer/submitter/github.py +++ b/rosdistro_reviewer/submitter/github.py @@ -16,9 +16,30 @@ GITHUB_TOKEN_ENVIRONMENT_VARIABLE = EnvironmentVariable( 'GITHUB_TOKEN', 'Authentication token secret for GitHub') -INTRODUCTION = """Hi there, thanks for contributing to ROS! +INTRODUCTION = """Thanks for sending a pull request to ROS distro! -This is an automated review generated by the [rosdistro-reviewer tool](https://github.com/ros-infrastructure/rosdistro-reviewer). If you'd like the tool to run again, just [re-request review from GitHub Actions](https://github.com/ros-infrastructure/rosdistro-reviewer?tab=readme-ov-file#running-rosdistro-reviewer-in-github-actions). +This is an automated tool that helps check your pull request for correctness. This tool checks a number of attributes associated with your ROS package and generates a report that helps our reviewers merge your pull request in a timely fashion. Here are a few things to consider when sending adding or updating a package to ROS Distro. ROS Distro includes a very helpful [CONTRIBUTING.md](https://github.com/ros/rosdistro/blob/master/CONTRIBUTING.md) file that we recommend reading if it is your first time submitting a package. Please also read the [ROS Distro review guidelines](https://github.com/rosdistro/rosdistro/blob/master/REVIEW_GUIDELINES.md) which summarizes this release process. + +If you'd like to run this tool again to generate a new review for your PR, just [re-request review from GitHub Actions](https://github.com/ros-infrastructure/rosdistro-reviewer?tab=readme-ov-file#running-rosdistro-reviewer-in-github-actions). + +# ROS Distro Considerations +* ROS Distribtutions are created using [REP-134 Standards Track](https://ros.org/reps/rep-0143.html) as a guide. +* Your package name should comply to [REP-144 ROS Package Naming](https://www.ros.org/reps/rep-0144.html) +* Your pacakge must build for all platforms and architectures on the ROS buildfarm. See [REP-2000 ROS Releases and Supported Platforms](https://www.ros.org/reps/rep-2000.html) for all supported platforms for your ROS Distro. +* Your package must contain an [OSI approved license](https://opensource.org/licenses). Your `package.xml` file must also include that license in a machine readable format. See [REP-149 Package Manifest Format Three Specification](https://ros.org/reps/rep-0149.html#license-multiple-but-at-least-one) for additional details. +* Your package must include a copyright at the top of every file. +* A publicly available, open source, repository for your ROS package. +* While not required, we recommend that you create an account for ROS Discourse and subscribe to the [appropriate release topic](https://discourse.ros.org/c/release/16). +* If you real time chat would help you resolve an issue please join our [Discord Server] and join the `#infra-help` channel. + +# Package Considerations + +Having your package included in a ROS Distro is a badge of quality, and we recommend that package developers strive to create packages of the highest quality. We recommend package developers review the following resources before submitting their package. + +* [REP-2004 Package Quality Declaration](https://www.ros.org/reps/rep-2004.html)-- The ROS 2 TGC has created a quality rating system for ROS packages. These ratings should serve as a guide for package developers. We recommend package developers achieve a quality level of three or higher. +* Documentation -- at minimum ROS packages should include an extensive [README.md file, and API level documentation using the Sphinx documentation system](https://docs.ros.org/en/rolling/How-To-Guides/Documenting-a-ROS-2-Package.html). +* Maintainer Responsibilities -- the ROS 2 documentation includes a guide to [ROS package maintainer responsibilities](https://docs.ros.org/en/rolling/How-To-Guides/Core-maintainer-guide.html) that summarizes your responsibilities as an open source maintainer. +* Your package should strive to conform to the [ROS 2 Developer Guide](https://docs.ros.org/en/rolling/The-ROS2-Project/Contributing/Developer-Guide.html) and the [ROS 2 Style Guide](https://docs.ros.org/en/rolling/The-ROS2-Project/Contributing/Code-Style-Language-Versions.html). --- From 6033e4484e593879174c1e02e6e53f46eae4ce3a Mon Sep 17 00:00:00 2001 From: Scott K Logan Date: Fri, 8 Nov 2024 12:51:48 -0600 Subject: [PATCH 2/5] No just Co-authored-by: Chris Lalancette --- rosdistro_reviewer/submitter/github.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rosdistro_reviewer/submitter/github.py b/rosdistro_reviewer/submitter/github.py index 7468876..7e4a229 100644 --- a/rosdistro_reviewer/submitter/github.py +++ b/rosdistro_reviewer/submitter/github.py @@ -20,7 +20,7 @@ This is an automated tool that helps check your pull request for correctness. This tool checks a number of attributes associated with your ROS package and generates a report that helps our reviewers merge your pull request in a timely fashion. Here are a few things to consider when sending adding or updating a package to ROS Distro. ROS Distro includes a very helpful [CONTRIBUTING.md](https://github.com/ros/rosdistro/blob/master/CONTRIBUTING.md) file that we recommend reading if it is your first time submitting a package. Please also read the [ROS Distro review guidelines](https://github.com/rosdistro/rosdistro/blob/master/REVIEW_GUIDELINES.md) which summarizes this release process. -If you'd like to run this tool again to generate a new review for your PR, just [re-request review from GitHub Actions](https://github.com/ros-infrastructure/rosdistro-reviewer?tab=readme-ov-file#running-rosdistro-reviewer-in-github-actions). +If you'd like to run this tool again to generate a new review for your PR, [re-request review from GitHub Actions](https://github.com/ros-infrastructure/rosdistro-reviewer?tab=readme-ov-file#running-rosdistro-reviewer-in-github-actions). # ROS Distro Considerations * ROS Distribtutions are created using [REP-134 Standards Track](https://ros.org/reps/rep-0143.html) as a guide. From f4f160f435a565200ce801f89476c79027ba4574 Mon Sep 17 00:00:00 2001 From: Scott K Logan Date: Fri, 8 Nov 2024 13:01:33 -0600 Subject: [PATCH 3/5] PR fixes Co-authored-by: Chris Lalancette --- rosdistro_reviewer/submitter/github.py | 13 ++++++------- test/spell_check.words | 2 ++ 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/rosdistro_reviewer/submitter/github.py b/rosdistro_reviewer/submitter/github.py index 7e4a229..6461f46 100644 --- a/rosdistro_reviewer/submitter/github.py +++ b/rosdistro_reviewer/submitter/github.py @@ -23,23 +23,22 @@ If you'd like to run this tool again to generate a new review for your PR, [re-request review from GitHub Actions](https://github.com/ros-infrastructure/rosdistro-reviewer?tab=readme-ov-file#running-rosdistro-reviewer-in-github-actions). # ROS Distro Considerations -* ROS Distribtutions are created using [REP-134 Standards Track](https://ros.org/reps/rep-0143.html) as a guide. +* ROS Distributions are created using [REP-134 Standards Track](https://ros.org/reps/rep-0143.html) as a guide. * Your package name should comply to [REP-144 ROS Package Naming](https://www.ros.org/reps/rep-0144.html) -* Your pacakge must build for all platforms and architectures on the ROS buildfarm. See [REP-2000 ROS Releases and Supported Platforms](https://www.ros.org/reps/rep-2000.html) for all supported platforms for your ROS Distro. +* Your package must build for all platforms and architectures on the ROS buildfarm. See [REP-2000 ROS Releases and Supported Platforms](https://www.ros.org/reps/rep-2000.html) for all supported platforms for your ROS Distro. * Your package must contain an [OSI approved license](https://opensource.org/licenses). Your `package.xml` file must also include that license in a machine readable format. See [REP-149 Package Manifest Format Three Specification](https://ros.org/reps/rep-0149.html#license-multiple-but-at-least-one) for additional details. -* Your package must include a copyright at the top of every file. * A publicly available, open source, repository for your ROS package. * While not required, we recommend that you create an account for ROS Discourse and subscribe to the [appropriate release topic](https://discourse.ros.org/c/release/16). -* If you real time chat would help you resolve an issue please join our [Discord Server] and join the `#infra-help` channel. +* If you would like, you may join our [Discord Server](https://discord.com/servers/open-robotics-1077825543698927656) and ask questions in the `#infra-help` channel. # Package Considerations Having your package included in a ROS Distro is a badge of quality, and we recommend that package developers strive to create packages of the highest quality. We recommend package developers review the following resources before submitting their package. -* [REP-2004 Package Quality Declaration](https://www.ros.org/reps/rep-2004.html)-- The ROS 2 TGC has created a quality rating system for ROS packages. These ratings should serve as a guide for package developers. We recommend package developers achieve a quality level of three or higher. -* Documentation -- at minimum ROS packages should include an extensive [README.md file, and API level documentation using the Sphinx documentation system](https://docs.ros.org/en/rolling/How-To-Guides/Documenting-a-ROS-2-Package.html). +* [REP-2004 Package Quality Declaration](https://www.ros.org/reps/rep-2004.html)-- The ROS 2 TSC has created a quality rating system for ROS packages. These ratings should serve as a guide for package developers. We recommend package developers achieve a quality level of three or higher. +* Documentation -- it is recommended that ROS packages include an extensive [README.md file, and API level documentation using the Sphinx documentation system](https://docs.ros.org/en/rolling/How-To-Guides/Documenting-a-ROS-2-Package.html). * Maintainer Responsibilities -- the ROS 2 documentation includes a guide to [ROS package maintainer responsibilities](https://docs.ros.org/en/rolling/How-To-Guides/Core-maintainer-guide.html) that summarizes your responsibilities as an open source maintainer. -* Your package should strive to conform to the [ROS 2 Developer Guide](https://docs.ros.org/en/rolling/The-ROS2-Project/Contributing/Developer-Guide.html) and the [ROS 2 Style Guide](https://docs.ros.org/en/rolling/The-ROS2-Project/Contributing/Code-Style-Language-Versions.html). +* We recommend that your package should strive to conform to the [ROS 2 Developer Guide](https://docs.ros.org/en/rolling/The-ROS2-Project/Contributing/Developer-Guide.html) and the [ROS 2 Style Guide](https://docs.ros.org/en/rolling/The-ROS2-Project/Contributing/Code-Style-Language-Versions.html). --- diff --git a/test/spell_check.words b/test/spell_check.words index 9332143..fe5c88b 100644 --- a/test/spell_check.words +++ b/test/spell_check.words @@ -10,6 +10,7 @@ corge debian deserialized diffs +distro eoan filepath fixturenames @@ -34,6 +35,7 @@ mypy namedtuple noop noqa +opensource patchset pathlib plugin From f57bb9ab92214415cf87a5fff8af0b3a28c7ee1a Mon Sep 17 00:00:00 2001 From: Scott K Logan Date: Fri, 8 Nov 2024 13:04:55 -0600 Subject: [PATCH 4/5] Add 'buildfarm' to dictionary --- test/spell_check.words | 1 + 1 file changed, 1 insertion(+) diff --git a/test/spell_check.words b/test/spell_check.words index fe5c88b..7ef2f4d 100644 --- a/test/spell_check.words +++ b/test/spell_check.words @@ -3,6 +3,7 @@ apache archlinux autouse bubblify +buildfarm colcon committish connectionpool From c096a7b8d1aec67bbd5a8ba7fe48e20fdf865d78 Mon Sep 17 00:00:00 2001 From: Scott K Logan Date: Thu, 14 Nov 2024 12:11:08 -0600 Subject: [PATCH 5/5] PR feedback --- rosdistro_reviewer/submitter/github.py | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/rosdistro_reviewer/submitter/github.py b/rosdistro_reviewer/submitter/github.py index 6461f46..9987f52 100644 --- a/rosdistro_reviewer/submitter/github.py +++ b/rosdistro_reviewer/submitter/github.py @@ -18,7 +18,10 @@ INTRODUCTION = """Thanks for sending a pull request to ROS distro! -This is an automated tool that helps check your pull request for correctness. This tool checks a number of attributes associated with your ROS package and generates a report that helps our reviewers merge your pull request in a timely fashion. Here are a few things to consider when sending adding or updating a package to ROS Distro. ROS Distro includes a very helpful [CONTRIBUTING.md](https://github.com/ros/rosdistro/blob/master/CONTRIBUTING.md) file that we recommend reading if it is your first time submitting a package. Please also read the [ROS Distro review guidelines](https://github.com/rosdistro/rosdistro/blob/master/REVIEW_GUIDELINES.md) which summarizes this release process. +This is an automated tool that helps check your pull request for correctness. +This tool checks a number of attributes associated with your ROS package and generates a report that helps our reviewers merge your pull request in a timely fashion. Here are a few things to consider when sending adding or updating a package to ROS Distro. +ROS Distro includes a very helpful [CONTRIBUTING.md](https://github.com/ros/rosdistro/blob/master/CONTRIBUTING.md) file that we recommend reading if it is your first time submitting a package. +Please also read the [ROS Distro review guidelines](https://github.com/rosdistro/rosdistro/blob/master/REVIEW_GUIDELINES.md) which summarizes this release process. If you'd like to run this tool again to generate a new review for your PR, [re-request review from GitHub Actions](https://github.com/ros-infrastructure/rosdistro-reviewer?tab=readme-ov-file#running-rosdistro-reviewer-in-github-actions). @@ -37,9 +40,13 @@ * [REP-2004 Package Quality Declaration](https://www.ros.org/reps/rep-2004.html)-- The ROS 2 TSC has created a quality rating system for ROS packages. These ratings should serve as a guide for package developers. We recommend package developers achieve a quality level of three or higher. * Documentation -- it is recommended that ROS packages include an extensive [README.md file, and API level documentation using the Sphinx documentation system](https://docs.ros.org/en/rolling/How-To-Guides/Documenting-a-ROS-2-Package.html). -* Maintainer Responsibilities -- the ROS 2 documentation includes a guide to [ROS package maintainer responsibilities](https://docs.ros.org/en/rolling/How-To-Guides/Core-maintainer-guide.html) that summarizes your responsibilities as an open source maintainer. +* Maintainer Responsibilities -- the ROS 2 documentation includes a guide to [ROS package maintainer responsibilities](https://docs.ros.org/en/rolling/How-To-Guides/Core-maintainer-guide.html) that summarizes your responsibilities as an open source maintainer. While we do not enforce these requirements on package maintainers they should be considered best practices. * We recommend that your package should strive to conform to the [ROS 2 Developer Guide](https://docs.ros.org/en/rolling/The-ROS2-Project/Contributing/Developer-Guide.html) and the [ROS 2 Style Guide](https://docs.ros.org/en/rolling/The-ROS2-Project/Contributing/Code-Style-Language-Versions.html). +# Need Help? + +Please post your questions to [Robotics Stack Exchange](https://docs.ros.org/) or refer to the `#infra-help` channel on our [Discord server](https://discord.com/servers/open-robotics-1077825543698927656). + --- """ # noqa: E501