Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What changes should go into the 0.2.5 release? (End of Sept release) #1187

Closed
ghost opened this issue Oct 1, 2019 · 10 comments
Closed

What changes should go into the 0.2.5 release? (End of Sept release) #1187

ghost opened this issue Oct 1, 2019 · 10 comments

Comments

@ghost
Copy link

ghost commented Oct 1, 2019 •
edited by ruffsl
Loading

This is the set of commits that have gone into master since the 0.2.4 release. What commits should go into 0.2.5?

  • a05c944 2019-10-01 'Carl Delsey' Sphinx Docs - Template Only (Sphinx Docs - Template Only #1138)
  • a0a9eb2 2019-10-01 'Steven Macenski' Merge pull request Wait recovery #1176 from SteveMacenski/wait_Recovery
  • 691abe3 2019-10-01 'stevemacenski' using builtin msgs duration
  • ec834a5 2019-10-01 'Carlos A. Orduno' [multirobot - Part4] Multiple robot control via RVIZ ([multirobot - Part4] Multiple robot control via RVIZ - Fix merge #1178)
  • 21a3b11 2019-10-01 'stevemacenski' check for negative or zero values in duration
  • e9e96a3 2019-10-01 'stevemacenski' remove unnecessary indentations
  • 2c84c53 2019-09-30 'stevemacenski' adding wait recovery into recovery behavior tree
  • 0d21ddd 2019-09-30 'stevemacenski' removing extraneous copy of extra bt
  • e17b29e 2019-09-30 'stevemacenski' wait recovery behavior
  • 4d80d5d 2019-09-30 'stevemacenski' nav2 recovery interface for bt navigator wait
  • 8e88686 2019-09-30 'Ruffin' Merge pull request Use ament index to resolve rosdep install #1142 from ros-planning/update_dockerfile
  • 818ae9d 2019-09-19 'ruffsl' Use ament index to resolve rosdep install
  • 0df1713 2019-09-30 'Ruffin' Merge pull request Fix underlay parameter for install_overlay_dependencies #1158 from ros-planning/ruffsl-patch-1
  • ba9cba7 2019-09-30 'bpwilcox' add sleep before checking for collision, remove nav2_dynamic_params from test suite
  • 46b3295 2019-09-30 'Steven Macenski' Merge pull request Nav2 recovery server #1131 from SteveMacenski/nav2_recovery_server
  • 0fa1a95 2019-09-30 'Carlos A. Orduno' [multirobot - Part3] Add multi-robot launching ([multirobot - Part3] Add multi-robot launching #1148)
  • e96d185 2019-09-30 'ruffsl' Always build underlay as release
  • 180814b 2019-09-30 'stevemacenski' Merge branch 'master' of github.com:ros-planning/navigation2 into nav2_recovery_server
  • 7063776 2019-09-17 'Matthew Hansen' Update behavior tree with local and global recoveries
  • fa82367 2019-09-30 'stevemacenski' fixing backup recovery crash from null node ptr
  • 9517be7 2019-09-27 'Carlos A. Orduno' Fix linter errors (Fix linter errors #1174)
  • 50c3157 2019-09-27 'stevemacenski' adding onCleanup and declaring params in constructor
  • c9d4241 2019-09-27 'Steven Macenski' Merge pull request prevent dwb controller from missing changes to the global path (#1160) #1169 from Jconn/issues/1160_listen_to_goal_changes
  • 90e7a99 2019-09-26 'Steven Macenski' Merge pull request Fixed documentation typo. #1171 from shivaang12/doc-recovery-typo
  • d22b681 2019-09-26 'Shivang Patel' Fixed documentation typo.
  • bcc9fd0 2019-09-25 'johnconn' prevent dwb controller from missing changes to the global path (dwb controller sometimes doesn't pick up changes to the global plan for the entire navigation goal #1160)
  • 226f06c 2019-09-25 'Carlos A. Orduno' [multirobot] Add namespacing to nav stack. ([multirobot - Part2] Add namespacing to nav stack #1147)
  • a0ee02e 2019-09-25 'Carlos A. Orduno' [multirobot] Spawn multiple robots into Gazebo ([multirobot - Part 1] Spawn multiple robots into Gazebo #1146)
  • 9c06186 2019-09-25 'Carlos A. Orduno' Fix planner server time bug (Set correct time in Planner #1165)
  • 0bf7f9c 2019-09-25 'Carlos A. Orduno' Enable deprecated warnings (Enable deprecated warnings #1167)
  • c0777fb 2019-09-25 'bpwilcox' check for always_reset_initial_pose flag in configure step
  • 0828c89 2019-09-23 'bpwilcox' reset initial pose with last known pose covariances
  • 2d368ca 2019-09-25 'Carlos Orduno' Fix typo
  • e40ffaf 2019-09-25 'stevemacenski' unique ptrs from shared ptrs
  • 78a0272 2019-09-24 'Melih Erdogan' Navigation 2 with SLAM Documentation (Navigation 2 with SLAM Documentation #1143)
  • 1193dbc 2019-09-24 'Carlos A. Orduno' Update design for providing transform to bt nodes (Update design for providing transform to bt nodes #1157)
  • 700f365 2019-09-24 'stevemacenski' shared recovery ptrs to unique
  • e9734e0 2019-09-24 'Ruffin' Add test for rmw_cyclonedds_cpp to nightly job
  • 206105c 2019-09-24 'stevemacenski' update recoveies_server_node -> recoveries_server & other feedback
  • da9cec6 2019-09-23 'Ruffin' Simplify checksum commands for consistency
  • f4e7048 2019-09-23 'Ruffin' Include complete path of checksum.txt in checksum
  • 555bd7f 2019-09-23 'Ruffin' Fix underlay parameter for install_overlay_dependencies
  • 8b8985e 2019-09-23 'Steven Macenski' Update test_system_launch.py
  • 704dbaf 2019-09-23 'stevemacenski' add memory header to recovery.hpp
  • b7c6761 2019-09-22 'bpwilcox' fix rebase issues / modify for autostart fix
  • 5f37f6e 2019-09-10 'bpwilcox' add pause, resume, and repeat button transitions
  • 544e06f 2019-09-10 'bpwilcox' add pausing/resuming states and slots
  • 5da8e21 2019-09-17 'bpwilcox' fix rebase issue
  • e6092fa 2019-09-17 'bpwilcox' return system status with timeout
  • 535aba0 2019-09-05 'bpwilcox' lint and uncrustify cleanup
  • 1f28d27 2019-09-04 'bpwilcox' add service/client for active system and call in Qthread
  • d8ab5d2 2019-09-20 'stevemacenski' fix merge conflict
  • 0c611ba 2019-09-20 'stevemacenski' merge commit
  • decb36f 2019-09-20 'Dan Rose' Change "the system" to "managed nodes"
  • 5f96f5b 2019-09-18 'bpwilcox' create action server on BtNavigator node
  • cc50e2e 2019-09-19 'bpwilcox' set first_map_received to false when cleaning up
  • 030a0e1 2019-09-18 'bpwilcox' declare_parameter_if_not_declared in navfnplanner
  • ea0524f 2019-09-19 'Yathartha Tuladhar' dwb_core.xml
  • 550e1d8 2019-09-17 'Yathartha Tuladhar' Plugin naming cleanup
  • ddb24c5 2019-09-16 'Yathartha Tuladhar' Addressing GCC diagnostic push, pop suggestion
  • c0bc531 2019-09-14 'Yathartha Tuladhar'
  • b900d0c 2019-09-13 'Yathartha Tuladhar' Cleanups and renames
  • 65eb602 2019-09-13 'Yathartha Tuladhar' Renaming, cleanup, and reintroduced TF buffer
  • 176dc7d 2019-09-12 'Yathartha Tuladhar' Fix linters and delete unused files
  • f510995 2019-09-12 'Yathartha Tuladhar' Enabling 3D messages for the planner interface
  • 243a8c7 2019-09-12 'Yathartha Tuladhar' Using dwb as plugin
  • 387d032 2019-09-12 'Yathartha Tuladhar' Creating nav2_controller, and deleting dwb_controller
  • 597c918 2019-09-12 'Yathartha Tuladhar' nav2_core interface, with lifecycle changes and cleanup
  • f2a9fb7 2019-09-19 'Ruffin' Merge pull request Colcon mixin now installed from base image #1127 from ros-planning/update_dockerfile
  • 77f3a61 2019-09-19 'Yathartha Tuladhar' Merge pull request Fix params file path for nav2_params in the system tests #1140 from yathartha3/params_file
  • c9b497b 2019-09-17 'ruffsl' Colcon mixin now installed from base image
  • 919aa32 2019-09-19 'Ruffin' Merge pull request Cache per packge.xml via multistage build #1122 from ruffsl/multistage_cache
  • 35e80f4 2019-09-19 'ruffsl' Cache both underlay and overlay layers
  • e486ae2 2019-09-19 'Yathartha Tuladhar' Fix params file path
  • b49a469 2019-09-17 'Ruffin' Update labels
  • a109760 2019-09-17 'Ruffin' Comment new directives
  • 6de6f2d 2019-09-17 'Ruffin' Revert FROM tag change
  • ce1724d 2019-09-16 'ruffsl' Include COLCON_IGNORE in cache
  • dce46bf 2019-09-16 'ruffsl' Cache per packge.xml via multistage
  • 0bfa19c 2019-09-18 'bpwilcox' fix deprecated publisher api issues (Fix deprecated publisher api issues #1133)
  • 44dcd60 2019-09-17 'Carlos A. Orduno' Refactored launch files (Refactored launch files #1118)
  • 2f6bb04 2019-09-17 'stevemacenski' Merge branch 'master' of github.com:ros-planning/navigation2 into nav2_recovery_server
  • bab0e81 2019-09-17 'stevemacenski' setting up on each fixture
  • 89da35d 2019-09-17 'stevemacenski' add more useful logging to test
  • de0aba5 2019-09-17 'stevemacenski' recoveries server bringup with lifecycle
  • 5ef79f7 2019-09-17 'Steven Macenski' Merge pull request Update lifecycle_manager_client.cpp #1132 from rotu/patch-2
  • 03775f6 2019-09-17 'Dan Rose' Update lifecycle_manager_client.cpp
  • ccefa77 2019-09-17 'stevemacenski' setting global transform listener and buffer
  • a133dfd 2019-09-17 'stevemacenski' linting nav2_recoveries
  • 16fda6a 2019-09-17 'Steven Macenski' Merge pull request remove nav2_dynamic_parameters #1128 from SteveMacenski/nukes
  • 9142f21 2019-09-17 'stevemacenski' remove nav2_dynamic_parameters
  • 448ee32 2019-09-16 'bpwilcox' remove reset of costmap_ros shared ptr
  • 8ee2726 2019-09-16 'stevemacenski' adding plugins
  • 68ba083 2019-09-16 'stevemacenski' templating node type for action server
  • cd22a7b 2019-09-16 'stevemacenski' properly registering plugins
  • 7c3dca2 2019-09-16 'stevemacenski' spin should also work in other direction for singularity
  • 99f0518 2019-09-16 'stevemacenski' temporarily removing executeRecovery method for further discussion
  • 1ff6bb7 2019-09-16 'stevemacenski' adding first prototypes of spin/backup recoveries
  • 4c3e788 2019-09-16 'stevemacenski' adding pluginlib dependencies
  • 61eb382 2019-09-16 'stevemacenski' update recovery and global planner to use shared_ptr tf buffers
  • 11b73c3 2019-09-16 'stevemacenski' changing bringup for new recoveries servern ode
  • 2b9f87e 2019-09-16 'stevemacenski' nav2 recovery server loading via pluginlib
  • 44a0a6f 2019-09-16 'stevemacenski' build with recovery server
  • ff9352e 2019-09-16 'stevemacenski' update nav2_recoveries to consume nav2_core
  • 4973026 2019-09-16 'Yathartha Tuladhar' updated setting of ros-args (updated deprecated setting of ros-args  #1120)
  • 1781a5b 2019-09-13 'Steven Macenski' Merge pull request move costmap in nav2_planner to shared_ptr and node to rclcpp lifecycle #1117 from SteveMacenski/planner_pkg2
  • 6753cd6 2019-09-13 'stevemacenski' move costmap in nav2_planner to shared_ptr and node to rclcpp lifecycle
  • a2b8ed9 2019-09-13 'Steven Macenski' Merge pull request Nav2 Planner + Navfn plugin #1107 from SteveMacenski/planner_pkg
  • 32d36f8 2019-09-13 'Ruffin' Merge pull request Add current workspace to the rosdep install command #1115 from crdelsey/circleci-rosdep
  • 3e05f5d 2019-09-13 'Carl Delsey' Add current workspace to the rosdep install command
  • 3112a3d 2019-09-13 'stevemacenski' review comment update for nav2_planner
  • fa92240 2019-09-13 'Carl Delsey' Fix execute process calls to use new parameter format. (Fix ExecuteProcess actions to use new parameter format. #1113)
  • 7a8ab47 2019-09-05 'bpwilcox' remove extra Qstates and rename idle state
  • e60db7c 2019-09-05 'Melih Erdogan' removed the apt-get install dependency list
  • e72a523 2019-08-30 'Melih Erdogan' added a new dependency to the list and updated ROS 2 dependencies the link
  • ee184fc 2019-09-12 'Matt Hansen' Delete .gitignore
  • 173206c 2019-09-05 'Carl Delsey' Fixing missing boost dependency
  • 19e30bd 2019-09-05 'Carl Delsey' Fix dependency exports
  • 816db29 2019-09-11 'Dan Rose' Remove backticks
  • a8ffd73 2019-09-09 'Dan Rose' Adjust issue template
  • 577fb6c 2019-09-11 'stevemacenski' nav2_utils->nav2_util
  • 0d86305 2019-09-11 'bpwilcox' fix uncrustify
  • f637981 2019-09-11 'bpwilcox' add ros args flag to costmap
  • 19dd330 2019-09-10 'Matthew Hansen' ucrustify static layer
  • cc5b9bb 2019-09-10 'Matthew Hansen' Fix typo -initialized-
  • 884483f 2019-09-10 'Matthew Hansen' Throw runtime_error instead of string
  • 446ae7f 2019-09-10 'Matthew Hansen' Remove try/catch for updateMap()
  • f4e7b48 2019-09-10 'Matthew Hansen' Change ERROR to throttled WARN
  • 7a4d598 2019-08-30 'Melih Erdogan' in static layer set a flag to check if map is received
  • 0216150 2019-08-30 'Melih Erdogan' throw exception when costmap is not initialized
  • 445fe6f 2019-08-22 'Matthew Hansen' Add support for running nav2 with cartographer
  • 8285163 2019-09-11 'stevemacenski' readding intel copyright headers
  • 9c4367d 2019-09-11 'Steven Macenski' Update nav2_planner/src/planner_server.cpp
  • 8e6b959 2019-09-11 'Steven Macenski' Update nav2_navfn_planner/src/navfn_planner.cpp
  • b0eda85 2019-09-11 'Steven Macenski' Update nav2_navfn_planner/src/navfn_planner.cpp
  • 82f56f7 2019-09-11 'Steven Macenski' Update nav2_navfn_planner/README.md
  • c6ec564 2019-09-11 'stevemacenski' replace navfn_planner lifecycle bringup with nav2_planner
  • ec34755 2019-09-10 'Ruffin' Merge pull request Remove COLCON_IGNORE from nav2_system_tests #1106 from ruffsl/rm_colcon_ignore
  • 446925e 2019-09-10 'stevemacenski' refining nav planner plugin for use in the nav2_planner
  • 85f32dc 2019-09-10 'stevemacenski' updating shared ptr for use in the global planner plugin
  • 51e8663 2019-09-10 'Ruffin' Revert branch typo
  • af402c5 2019-09-10 'stevemacenski' registering pluginlib global planner plugin
  • ccc3617 2019-09-10 'Matthew Hansen' Add arguments for joint state remapping
  • 4565252 2019-09-09 'Carl Delsey' Adding -r and --ros-args where needed.
  • cf53004 2019-09-09 'Matthew Hansen' Add QOS policies to system test
  • c79b432 2019-09-09 'Matthew Hansen' Change test world to use new arguments flags
  • eec7127 2019-09-10 'ruffsl' Remove COLCON_IGNORE
  • e342010 2019-08-30 'bpwilcox' integrate declare if not declared parameters through dwb
  • 0e1e765 2019-08-30 'bpwilcox' declare if not declared parameters for costmap plugins
  • 867b03b 2019-09-10 'stevemacenski' update documents for nav2_planner with navfn plugin
  • 7dee2ea 2019-09-10 'stevemacenski' adding nav2_planner to bringup
  • b1b33bf 2019-09-10 'stevemacenski' base nav2 planning server
  • a473526 2019-09-10 'stevemacenski' navfn package to plugin
  • 92a50aa 2019-09-10 'stevemacenski' updating dwb for removal of nav2_msgs
  • fc9ab5d 2019-09-10 'stevemacenski' updating global and recovery base type headers
  • 465e4e1 2019-09-10 'stevemacenski' removing nav2_msgs/path in favor of nav_msgs/Path which inherently contains more information
  • 41da7b8 2019-09-10 'Steven Macenski' Merge pull request Move Costmap into NavFn process #1089 from SteveMacenski/model_navfn
  • 0c5641f 2019-09-10 'Steven Macenski' Merge pull request map_loader: add SDL include directories #1101 from lopsided98/map-loader-sdl-include
  • 71d5d71 2019-09-10 'stevemacenski' change default state in case of first hit TF failure & hundred test 3 times for similar
  • 4efa735 2019-09-10 'stevemacenski' removing overloaded collision/tolerance methods
  • 675717d 2019-09-10 'stevemacenski' add activation in node tests
  • 50bb913 2019-09-10 'stevemacenski' merge conflict resolution from global planner test updates
  • 6993fcd 2019-09-09 'Carlos A. Orduno' Improvements to global planner tests (Improvements to global planner tests #1083)
  • 41eeab2 2019-09-09 'stevemacenski' updating versions to current 0.2.4
  • 183d6ec 2019-09-09 'stevemacenski' moving cost_value header from navfn_planner.hpp to .cpp
  • b87942a 2019-09-06 'Ben Wolsieffer' map_loader: add SDL include directories
  • 0514c9a 2019-09-06 'stevemacenski' removing debug artifacts
  • cba1e8c 2019-09-05 'bpwilcox' change srv name, remove msg
  • d5f1dcc 2019-08-29 'bpwilcox' fix lint and uncrustify issues
  • 0363a17 2019-08-29 'bpwilcox' remove reason srv string
  • 5aa6b51 2019-08-29 'bpwilcox' add pause, resume, reset to manager client
  • f5ef0d0 2019-08-28 'bpwilcox' create custom lifecycle manager srv
  • 94f06fb 2019-08-28 'bpwilcox' configure and activate all nodes separately
  • 240bcef 2019-09-05 'Steven Macenski' Merge pull request Nav2 core #1087 from SteveMacenski/nav2_core
  • e18090b 2019-09-05 'stevemacenski' update licenses in nav2_core to be Apache
  • 41a4873 2019-09-04 'stevemacenski' updating nav_core2 license to apache
  • 78854bd 2019-09-04 'stevemacenski' plugins receive lifecycle node pointers
  • fb25e8f 2019-09-04 'stevemacenski' fixed CI issues from incorrect static map state and others
@orduno
Copy link
Contributor

orduno commented Oct 1, 2019 •
edited
Loading

(I'll be updating this comment as I check more items from the list)

Checked items:

  • Checking 1193dbc as there's an issue reported the bug on Dashing.
  • 0bf7f9c is kind of minor, doesn't hut getting in.
  • 2d368ca a minor typo fix.

Questions:

  • We got a long list 😨. Can we discuss in general what features we want in? We have:
    • Multi-robot
    • Global planner refactors
    • Local planner refactors
    • Recoveries refactors
    • others?

@ghost
Copy link
Author

ghost commented Oct 2, 2019

We got a long list.

Yeah. Tell me about it. I kind of gave up last month on being surgical and just merged everything. That lead to merging something that shouldn't have been merged. I would not have known it wasn't supposed to be merged, though. I think we need the authors, or at least someone familiar with the change to make the call on whether it should be backported. It would be nice if we added a flag to PRs to say whether we want to backport or not, but right now, there's no way to enforce that.

Can we discuss in general what features we want in?

After discussing a bit yesterday, I'm of the opinion we just want to back port bug fixes to dashing at this point. Eloquent is not that far away, and Dashing is usable, so we don't need to back port features

@SteveMacenski
Copy link
Member

After discussing a bit yesterday, I'm of the opinion we just want to back port bug fixes to dashing at this point. Eloquent is not that far away, and Dashing is usable, so we don't need to back port features

I think that's typically what OSRF recommends anyhow. I don't necessarily subscribe to that mentality, but there's too much entropy in this project and its not a good use of your time to try to knit-pick features as you've mentioned. 👍 for back porting genuine bugs only

@mkhansenbot
Copy link
Collaborator

After discussing a bit yesterday, I'm of the opinion we just want to back port bug fixes to dashing at this point. Eloquent is not that far away, and Dashing is usable, so we don't need to back port features

Seeing this list I agree.

@mkhansenbot
Copy link
Collaborator

I submitted a PR #1193 directly to the dashing devel branch as a bug fix that needs to be merged before 0.2.5

@ruffsl
Copy link
Member

ruffsl commented Oct 3, 2019

Any of my commits for patching the CI should be fine, given they don't intersect with the nav2 code. It could help keep the CI consistent when testing PRs for backporting to dashing. Though, I may need to tweek the docker hooks on the dashing branch to switch the executor image from ros2 nightly to dashing.

@mkhansenbot
Copy link
Collaborator

@ruffsl - can you check the boxes above for the commits you want backported?

Though, I may need to tweek the docker hooks on the dashing branch to switch the executor image from ros2 nightly to dashing.

It would be great if you could fix the CI on the dashing branch! 👍

@ghost
Copy link
Author

ghost commented Oct 3, 2019

@orduno I'm not going to bring in 0bf7f9c, or else I'd also need to bring in the changes that replace the deprecated functions. I don't think we really need that in the dashing release.

@SteveMacenski
Copy link
Member

@crdelsey #1198 was merged, should I do a release?

@SteveMacenski
Copy link
Member

closing and doing release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ruffsl @mkhansenbot @SteveMacenski @orduno