Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suspicious code in getConversionCode() #533

Closed
galou opened this issue May 6, 2024 · 1 comment
Closed

Suspicious code in getConversionCode() #533

galou opened this issue May 6, 2024 · 1 comment

Comments

@galou
Copy link

galou commented May 6, 2024

In getConversionCode, there a some suspicious addition of || enc::isMono(src_encoding) in the code to determine if the source encoding (is_src_color_format) is a color one. Same for is_dst_color_format.

I can write a PR.
@galou
Copy link
Author

galou commented May 6, 2024

Cf. #431

@galou galou closed this as completed May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@galou