From ac2a9a30f6337d71c925ad28c29fe4d65e91096e Mon Sep 17 00:00:00 2001 From: Christophe Bedard Date: Tue, 11 Feb 2025 17:24:15 -0800 Subject: [PATCH] Do not ignore 'rosdep install' failures/errors Signed-off-by: Christophe Bedard --- dist/index.js | 2 +- src/action-ros-ci.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dist/index.js b/dist/index.js index 9ad9b771..c6a3a968 100644 --- a/dist/index.js +++ b/dist/index.js @@ -30878,7 +30878,7 @@ function installRosdeps(packageSelection, skipKeys, workspaceDir, options, ros1D # suppress errors from unresolved install keys to preserve backwards compatibility # due to difficulty reading names of some non-catkin dependencies in the ros2 core # see https://index.ros.org/doc/ros2/Installation/Foxy/Linux-Development-Setup/#install-dependencies-using-rosdep - rosdep install -r --from-paths $package_paths --ignore-src --skip-keys "rti-connext-dds-5.3.1 rti-connext-dds-6.0.1 ${filterNonEmptyJoin(skipKeys)}" --rosdistro $DISTRO -y || true`; + rosdep install -r --from-paths $package_paths --ignore-src --skip-keys "rti-connext-dds-5.3.1 rti-connext-dds-6.0.1 ${filterNonEmptyJoin(skipKeys)}" --rosdistro $DISTRO -y`; fs_1.default.writeFileSync(scriptPath, scriptContent, { mode: 0o766 }); let exitCode = 0; if (ros1Distro) { diff --git a/src/action-ros-ci.ts b/src/action-ros-ci.ts index 19c7bd8a..95fdf847 100644 --- a/src/action-ros-ci.ts +++ b/src/action-ros-ci.ts @@ -202,7 +202,7 @@ async function installRosdeps( # see https://index.ros.org/doc/ros2/Installation/Foxy/Linux-Development-Setup/#install-dependencies-using-rosdep rosdep install -r --from-paths $package_paths --ignore-src --skip-keys "rti-connext-dds-5.3.1 rti-connext-dds-6.0.1 ${filterNonEmptyJoin( skipKeys, - )}" --rosdistro $DISTRO -y || true`; + )}" --rosdistro $DISTRO -y`; fs.writeFileSync(scriptPath, scriptContent, { mode: 0o766 }); let exitCode = 0;