Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph introspection incomplete when nodes with duplicate names present #84

Closed
Yadunund opened this issue Dec 13, 2023 · 1 comment
Closed
Assignees
Labels
bug Something isn't working

Comments

@Yadunund
Copy link
Member

Yadunund commented Dec 13, 2023

The current GraphCache implementation assumes nodes within a namespace will have unique names. But this is not necessarily true for ROS 2 nodes. Hence, with two talker nodes running, commands like ros2 node list will return only reveal a single /talker node.

Note: With DDS, GIDs are available for entities which are globally unique. With zenoh, each session will have a unique z_session_id.

Potential solutions:

  1. Update liveliness token keyexprs to also include the z_session_id of the entity. Then update NodeMap to be an std::multimap with a custom comparator that sorts based on the z_session_id.
@Yadunund
Copy link
Member Author

Yadunund commented Jan 4, 2024

Closed by #87

@Yadunund Yadunund closed this as completed Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant