Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maximize type-hints in a future PHP 7.2+ version #12

Open
rotexdegba opened this issue Dec 5, 2018 · 1 comment
Open

Maximize type-hints in a future PHP 7.2+ version #12

rotexdegba opened this issue Dec 5, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@rotexdegba
Copy link
Member

In a PHP 7.2+ version, go through all methods and remove type checking code (e.g. is_int checks) and replace with appropriately type-hinted params.

Also add return types to the interface.
@rotexdegba rotexdegba added the enhancement New feature or request label Dec 5, 2018
rotexdegba added a commit that referenced this issue Nov 10, 2019
@rotexdegba
https://github.com/rotexsoft/versatile-collections/issues/12.
d16c6c8 
Enabling strict typing and proper type hints for php 7.2+
rotexdegba added a commit that referenced this issue Nov 10, 2019
@rotexdegba
https://github.com/rotexsoft/versatile-collections/issues/12.
0e815ad 
Enabling strict typing and proper type hints for php 7.2+ and updated unit tests.
Getting ready for first stable 3.X release.
@rotexdegba
Copy link
Member Author

rotexdegba commented Nov 10, 2019 •
edited
Loading

Swept through the code and added typed parameters and return types where appropriate and updated tests accordingly, also got rid of some unnecessary type checking code. Also removed some php 5.6 - 7.1 poly-fill code. Will keep this issue open for a while just in case any other missed type-hinting opportunities are spotted and updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rotexdegba